Allow building with Clang using MSVC ABI

cristianadam · tordex · commit 09fd84d4ff66 · 2025-07-30T13:22:14.000+03:00
The official LLVM build of Clang is using the MSVC ABI, and
if you are using clang.exe and not clang-cl.exe you get the
GNU command line interface.

CMake would not set the MSVC variable, but the CMAKE_CXX_SIMULATE_ID
as "MSVC". Since clang.exe is targeting the MSVC ABI it needs
the build support the MSVC has.
diff --git a/src/gumbo/CMakeLists.txt b/src/gumbo/CMakeLists.txt
@@ -58,7 +58,7 @@ set_target_properties(${PROJECT_NAME} PROPERTIES
     PUBLIC_HEADER "${HEADER_GUMBO}"
 )
 
-if (MSVC)
+if (MSVC OR CMAKE_CXX_SIMULATE_ID STREQUAL "MSVC")
     target_include_directories(${PROJECT_NAME} PRIVATE visualc/include)
 endif()
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ set_target_properties(${PROJECT_NAME} PROPERTIES`
`58`	`58`	`PUBLIC_HEADER "${HEADER_GUMBO}"`
`59`	`59`	`)`
`60`	`60`
`61`		`-if (MSVC)`
	`61`	`+if (MSVC OR CMAKE_CXX_SIMULATE_ID STREQUAL "MSVC")`
`62`	`62`	`target_include_directories(${PROJECT_NAME} PRIVATE visualc/include)`
`63`	`63`	`endif()`
`64`	`64`