Add pyupgrade rules to ruff #12953
Add pyupgrade rules to ruff #12953
Conversation
giograno
added
the
semver: patch
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 41s ⏱️ Results for commit f040dd5. ♻️ This comment has been updated with latest results. |
giograno
force-pushed
the
pyupgrade
branch
11 times, most recently
from
7cf76e9 to
97c5a6f
Compare
Test Results - Alternative Providers1 078 tests 730 ✅ 45m 8s ⏱️ Results for commit f040dd5. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 20m 24s ⏱️ Results for commit f040dd5. ♻️ This comment has been updated with latest results. |
giograno
requested review from
sannya-singal,
pinzon,
dfangl,
MEPalma,
joe4dev,
gregfurman,
dominikschubert and
thrau
as code owners
giograno
removed request for
steffyP,
joe4dev,
macnev2013,
maxhoheiser,
dfangl,
pinzon,
gregfurman,
sannya-singal,
bentsku,
MEPalma,
cloutierMat and
baermat
There was a problem hiding this comment.
Awesome! From my perspective this is looking great! The changeset contains some very subtle changes which directly demonstrate why this kind of linting is a good idea to integrate! 💯
The only question that I still have is the same as for the PR in the downstream project:
How should we best merge this in order to cause the minimum amount of friction for other developers? Would be great if you could outline the different steps / the timeline and the implications (i.e. the steps contributors should take), before moving forward.
|
Thanks @alexrashed! My plan would be the following.
|
giograno
force-pushed
the
pyupgrade
branch
2 times, most recently
from
202c93b to
4d3b20b
Compare
See python/cpython#114315 for details
Motivation
This PR introduces Pyupgrade rules to our ruff configuration.
pyupgrade is a tool that automatically upgrades Python syntax to newer versions.
It introduces the same set of rules of pro#4989.
All the rules are automatically applied by the
make format. They are also part of the pre-commit hook (after amake init-precommit).Changes
PUrules to ourruffconfiguration. A few rules have been ignored asruffdoes not yet provide a fix that guarantees the program's behavior to stay the same.localstack-core/localstack/utils/**andlocalstack-core/localstack/testing/pytest/**) as they are imported from the CLI test.__init__files. The rationale is the same as the companion PR.PUrules for `tests/aws/services/lambda_/functions/**. These modules are used by Lambda tests that run with a bunch of different runtimes.I added a few self-contained commits to fix minor stuff I encountered, before committing the rules and all the formatting changes:
typing.Unionoutside of type annotations (e.g., right-hand side of an assignment), as they can't be safely fixed byruff.typing.ContextManagerin favor ofcontextlib.AbstractContextManager. This is an unsafe fix at the moment.jsonanddatetime). I fixed them in 4631eca and 20dca66.Optional[RLock]toRLock | None. In our Python version,RLockis not a type but a factory function. More info in the issue attached to the commit.convert_to_typed_dict.