DE-1570: Respond with error message for 400 Bad Request (#360)

alex-leb · web-flow · commit cf44f68de454 · 2025-07-23T18:25:51.000+03:00
* DE-1570: Respond with error message for 400 Bad Request

Signed-off-by: Alex Lebedev &lt;6421109+alex-leb@users.noreply.github.com&gt;

* DE-1570: fix specs

Signed-off-by: Alex Lebedev &lt;6421109+alex-leb@users.noreply.github.com&gt;

---------

Signed-off-by: Alex Lebedev &lt;6421109+alex-leb@users.noreply.github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,18 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.3.8] - 2025-07-23
+
+- Respond with error message for 400 Bad Request
+
+## [1.3.7] - 2025-06-29
+
+- Use proxy_url passed to constructor (https://github.com/mailgun/mailgun-ruby/pull/342)
+- Refactor to use UserNotifier instead of UserMailer for consistency (https://github.com/mailgun/mailgun-ruby/pull/323)
+- Add option to specify api key and host when initializing Address api (https://github.com/mailgun/mailgun-ruby/pull/328)
+- Remove base64 dependency (https://github.com/mailgun/mailgun-ruby/pull/313)
+- DE-1547: Support for the logs API (https://github.com/mailgun/mailgun-ruby/pull/356)
+
 ## [1.3.6] - 2025-05-30
 
 ### Fixed
diff --git a/README.md b/README.md
@@ -19,7 +19,7 @@ gem install mailgun-ruby
 Gemfile:
 
 ```ruby
-gem 'mailgun-ruby', '~>1.3.7'
+gem 'mailgun-ruby', '~>1.3.8'
 ```
 
 Usage
diff --git a/lib/mailgun/exceptions/exceptions.rb b/lib/mailgun/exceptions/exceptions.rb
@@ -46,11 +46,11 @@ def initialize(message = nil, response = nil)
       @status = if response.nil?
                 NOCODE
               else
-                response.status
+                response[:status]
               end
 
       begin
-        json = JSON.parse(response.body)
+        json = JSON.parse(response[:body])
         api_message = json['message'] || json['Error'] || json['error']
       rescue JSON::ParserError
         api_message = response.response_body
diff --git a/lib/mailgun/version.rb b/lib/mailgun/version.rb
@@ -1,4 +1,4 @@
 # It's the version. Yeay!
 module Mailgun
-  VERSION = '1.3.7'
+  VERSION = '1.3.8'
 end
diff --git a/spec/integration/mailgun_spec.rb b/spec/integration/mailgun_spec.rb
@@ -27,7 +27,7 @@
           :text => 'INTEGRATION TESTING'
       })
     rescue Mailgun::CommunicationError => err
-      expect(err.message).to eq('the server responded with status 404')
+      expect(err.message).to eq('the server responded with status 404: Domain not found: not-our-doma.in')
     else
       fail
     end
@@ -75,7 +75,7 @@
           :text => 'INTEGRATION TESTING'
       })
     rescue Mailgun::BadRequest => err
-      expect(err.message).to eq('the server responded with status 400')
+      expect(err.message).to eq('the server responded with status 400: to parameter is not a valid address. please check documentation')
     else
       fail
     end
diff --git a/spec/unit/exceptions/exceptions_spec.rb b/spec/unit/exceptions/exceptions_spec.rb
@@ -5,21 +5,21 @@
     context "when the Response body doesn't have a `message` property" do
       it "doesn't raise an error" do
         expect do
-          described_class.new('Boom!', Mailgun::Response.from_hash({ status: 401, body: '{}' }))
+          described_class.new('Boom!', { status: 401, body: '{}' })
         end.not_to raise_error
       end
 
       context "when the Response body has an `Error` property" do
         it "uses the `Error` property as the API message" do
-          subject = described_class.new('Boom!', Mailgun::Response.from_hash({ status: 401, body: '{"Error":"unauthorized"}' }))
+          subject = described_class.new('Boom!', { status: 401, body: '{"Error":"unauthorized"}' })
 
           expect(subject.message).to eq("Boom!: unauthorized")
         end
       end
 
       context "when the Response body has an `error` property" do
         it "uses the `Error` property as the API message" do
-          subject = described_class.new('Boom!', Mailgun::Response.from_hash({ status: 401, body: '{"error":"not found"}' }))
+          subject = described_class.new('Boom!', { status: 401, body: '{"error":"not found"}' })
 
           expect(subject.message).to eq("Boom!: not found")
         end
