tests: various improvements for Octoprobe (WIP) #17782
Draft
+225
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17782 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22283 22283
=======================================
Hits 21924 21924
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpgeorge
force-pushed
the
tests-improvements-for-octoprobe
branch
from
18ad8c0 to
5958518
Compare
|
Code size report: |
dpgeorge
force-pushed
the
tests-improvements-for-octoprobe
branch
from
c399b93 to
ca374fa
Compare
|
@dpgeorge: Two easy to reproduce bugs which could be added to ths PR |
dpgeorge
force-pushed
the
tests-improvements-for-octoprobe
branch
2 times, most recently
from
aee37bb to
8920560
Compare
dpgeorge
force-pushed
the
tests-improvements-for-octoprobe
branch
2 times, most recently
from
f066e45 to
780ca38
Compare
Signed-off-by: Damien George <[email protected]>
Some boards define ESP32C3, some define ESP32-C3. Probably it should just use default pins, eg SPI(1). Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
To get `micropython/extreme_exc.py` to pass when run via-mpy. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Eg for ESP8266-512K. Signed-off-by: Damien George <[email protected]>
In --via-mpy --emit native mode. Signed-off-by: Damien George <[email protected]>
On ESP8266 this test can fail with --via-mpy. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Because RP2350 uses float-abi=softfp! Maybe we should change that somehow? Could also use `defined(__SOFTFP__)` to detect soft (all software fp) or softfp (hardware for calculations but soft/integer for passing arguments). Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Tested on ADAFRUIT_ITSYBITSY_M0_EXPRESS. Signed-off-by: Damien George <[email protected]>
On RP2350 these must now be skipped with via-mpy, due to mpy-cross not knowing the correct architecture. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
On bare-metal lwIP targets, there's only enough buffer space for 4 groups. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
dpgeorge
force-pushed
the
tests-improvements-for-octoprobe
branch
from
66db214 to
3993063
Compare
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a collection of various small improvements to the test suite to get Octoprobe to pass more of the tests.
Once fully working, these changes will be made into separate PRs.
Testing
To be tested by Octoprobe: https://reports.octoprobe.org/
Test report prior to this PR: https://reports.octoprobe.org/github_selfhosted_testrun_194/octoprobe_summary_report.html
Test report with this PR: https://reports.octoprobe.org/github_selfhosted_testrun_199/octoprobe_summary_report.html