Skip to content

McpWorkbenchServer should not use ?? '' for unknown properties #252560

@connor4312

Description

@connor4312

We have the pattern of

return this.gallery?.id ?? this.local?.id ?? this.installable?.name ?? '';

This makes it easy for consumers to assume things will always be defined, as the interface says. We should instead make this undefined to ensure we're dealing with undefined properties everywhere it's appropriate to do so.

Metadata

Metadata

Labels

debtCode quality issues

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions