Skip to content

Verify Settings Auto-Refetch Compatibility for Experimental Configuration Values #257059

@sandy081

Description

@sandy081

Ref - https://github.com/microsoft/vscode-internalbacklog/issues/5545

With the experimental configuration system migration from onExP tag to structured experiment objects, many settings now have mode:'startup' by default. Eg:

'chat.editRequests': {
			tags: ['experimental'],
			experiment: {
				mode: 'startup'
			}
		}

This issue tracks the review of settings that could potentially handle automatic configuration changes when experiment values are updated, and identifies candidates for enabling mode: auto.

Detecting Experiment-Driven Configuration Changes

Components can detect when a configuration change originates because of Default value has update by checking the source property in the configuration change event. When event.source === ConfigurationTarget.DEFAULT.

this.configurationService.onDidChangeConfiguration(event => {
    if (event.source === ConfigurationTarget.DEFAULT && event.affectsConfiguration('your.setting.key')) {
        // This change came from default value change
        // Handle dynamic configuration change
    }
});

Settings Categories to Review:

For each setting, evaluate:

  1. Can the default setting value change dynamically without causing user experience disruptions?
  2. What happens if the setting changes automatically while the application is running?

Next Steps:

  1. Component owners review their assigned settings
  2. Update autoRefetch: true for settings that can handle dynamic changes

Metadata

Metadata

Labels

debtCode quality issuesengineeringVS Code - Build / issue tracking / etc.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions