From ba00f6d19bea00b328b1e935cfb8f2fcd5deb7f3 Mon Sep 17 00:00:00 2001 From: Ben Hardill Date: Tue, 5 Dec 2023 15:17:39 +0000 Subject: [PATCH 1/3] Backport #1752 (#1758) --- lib/client.js | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/lib/client.js b/lib/client.js index e90bd2261..25b76cac4 100644 --- a/lib/client.js +++ b/lib/client.js @@ -32,14 +32,6 @@ const defaultConnectOptions = { resubscribe: true } -const socketErrors = [ - 'ECONNREFUSED', - 'EADDRINUSE', - 'ECONNRESET', - 'ENOTFOUND' -] - -// Other Socket Errors: EADDRINUSE, ECONNRESET, ENOTFOUND. const errors = { 0: '', @@ -454,7 +446,9 @@ MqttClient.prototype._setupStream = function () { function streamErrorHandler (error) { debug('streamErrorHandler :: error', error.message) - if (socketErrors.includes(error.code)) { + // error.code will only be set on NodeJS env, browse don't allow to detect erros on sockets + // also emitting errors on browser seems to create issues + if (error.code) { // handle error debug('streamErrorHandler :: emitting error') that.emit('error', error) From 9c92246ca30dd47aa79a443bc220f108abbdeb2b Mon Sep 17 00:00:00 2001 From: Daniel Lando Date: Tue, 5 Dec 2023 16:22:26 +0100 Subject: [PATCH 2/3] Correct version --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index c15f95c14..87aff8ad7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "mqtt", - "version": "4.3.6", + "version": "4.3.7", "lockfileVersion": 2, "requires": true, "packages": { diff --git a/package.json b/package.json index 1bba6f5af..05256042b 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "mqtt", "description": "A library for the MQTT protocol", - "version": "4.3.6", + "version": "4.3.7", "contributors": [ "Adam Rudd ", "Matteo Collina (https://github.com/mcollina)", From c60a5d4bc5b473ed5c54cb96c35a0903ee51ad93 Mon Sep 17 00:00:00 2001 From: Daniel Lando Date: Tue, 5 Dec 2023 16:22:47 +0100 Subject: [PATCH 3/3] Bump v4.3.8 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 87aff8ad7..3eaf6d6d8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "mqtt", - "version": "4.3.7", + "version": "4.3.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "mqtt", - "version": "4.3.6", + "version": "4.3.8", "license": "MIT", "dependencies": { "commist": "^1.0.0", diff --git a/package.json b/package.json index 05256042b..c6014e338 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "mqtt", "description": "A library for the MQTT protocol", - "version": "4.3.7", + "version": "4.3.8", "contributors": [ "Adam Rudd ", "Matteo Collina (https://github.com/mcollina)",