PG-1710 Do not hardcode length of WAL filename

jeltz · jeltz · commit a994c3b5936c · 2025-07-29T21:52:54.000+02:00
There is a cosntant used by PostgreSQL itself.
diff --git a/contrib/pg_tde/src/bin/pg_tde_archive_decrypt.c b/contrib/pg_tde/src/bin/pg_tde_archive_decrypt.c
@@ -16,7 +16,7 @@
 static bool
 is_segment(const char *filename)
 {
-	return strspn(filename, "0123456789ABCDEF") == 24 && filename[24] == '\0';
+	return strspn(filename, "0123456789ABCDEF") == XLOG_FNAME_LEN && filename[XLOG_FNAME_LEN] == '\0';
 }
 
 static void
diff --git a/contrib/pg_tde/src/bin/pg_tde_restore_encrypt.c b/contrib/pg_tde/src/bin/pg_tde_restore_encrypt.c
@@ -16,7 +16,7 @@
 static bool
 is_segment(const char *filename)
 {
-	return strspn(filename, "0123456789ABCDEF") == 24 && filename[24] == '\0';
+	return strspn(filename, "0123456789ABCDEF") == XLOG_FNAME_LEN && filename[XLOG_FNAME_LEN] == '\0';
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`static bool`
`17`	`17`	`is_segment(const char *filename)`
`18`	`18`	`{`
`19`		`- return strspn(filename, "0123456789ABCDEF") == 24 && filename[24] == '\0';`
	`19`	`+ return strspn(filename, "0123456789ABCDEF") == XLOG_FNAME_LEN && filename[XLOG_FNAME_LEN] == '\0';`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`static void`