Fix bug #71041 dynamic embed SAPI load error

VBart · nikic · commit 11ddf7669a58 · 2018-11-20T21:30:02.000+01:00
If the library is built with ZEND_SIGNALS defined, it's unusable with an
external SAPI module because the zend_signal_startup() call is mandatory
in this case.

This bug is similar to #74149, but related to dynamic loading of PHP library.
diff --git a/NEWS b/NEWS
@@ -2,6 +2,10 @@ PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? 2018, PHP 7.1.25
 
+- Core:
+  . Fixed bug #71041 (zend_signal_startup() needs ZEND_API).
+    (Valentin V. Bartenev)
+
 - ftp:
   . Fixed bug #77151 (ftp_close(): SSL_read on shutdown). (Remi)
 
diff --git a/Zend/zend_signal.c b/Zend/zend_signal.c
@@ -399,7 +399,7 @@ void zend_signal_init(void) /* {{{ */
 
 /* {{{ zend_signal_startup
  * alloc zend signal globals */
-void zend_signal_startup(void)
+ZEND_API void zend_signal_startup(void)
 {
 
 #ifdef ZTS
diff --git a/Zend/zend_signal.h b/Zend/zend_signal.h
@@ -89,7 +89,7 @@ ZEND_API void zend_signal_handler_unblock(void);
 void zend_signal_activate(void);
 void zend_signal_deactivate(void);
 BEGIN_EXTERN_C()
-void zend_signal_startup(void);
+ZEND_API void zend_signal_startup(void);
 END_EXTERN_C()
 void zend_signal_init(void);
 

Original file line number	Diff line number	Diff line change
`@@ -399,7 +399,7 @@ void zend_signal_init(void) /* {{{ */`
`399`	`399`
`400`	`400`	`/* {{{ zend_signal_startup`
`401`	`401`	`* alloc zend signal globals */`
`402`		`-void zend_signal_startup(void)`
	`402`	`+ZEND_API void zend_signal_startup(void)`
`403`	`403`	`{`
`404`	`404`
`405`	`405`	`#ifdef ZTS`