Fix check for using computed goto flag for re2c#11928
Merged
petk merged 1 commit intophp:masterfrom Jun 25, 2024
Merged
Conversation
petk
force-pushed
the
patch-autoconf-re2c-cgoto
branch
from
d802f6d to
fc12ea8
Compare
Member
Author
|
I've fixed this now properly. Otherwise, now when using the Code compiles and tests succeed properly otherwise. |
When the computed goto extension is available to optimize conditional jumps, option --enable-re2c-cgoto adds the -g flag to re2c. In this case the AC_LANG_SOURCE is used instead of the AC_LANG_PROG to not wrap the compilation check program in another main() function. Code is also simplified and help messages updated. This is a compiler-agnostic extension, not only available with GCC. When the check is successful, the -g is added, otherwise not.
petk
force-pushed
the
patch-autoconf-re2c-cgoto
branch
from
fc12ea8 to
54c0c7f
Compare
Member
Author
|
Fix updated and adjusted. Targeting master branch (PHP-8.4-dev). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AC_LANG_SOURCE should be used instead of the AC_LANG_PROG so the compilation check can succeed when the computed goto extension is available to optimize conditional jumps. This one was missed when we were updating the Autoconf AC_TRY_COMPILE macros:
Steps to reproduce (Linux with GCC):
The -g flag for re2c isn't enabled (but could be):
Update: This needs to be further fixed. This isn't working either.