random: Initialize the mode field when seeding in php_random_default_status()#13690
Merged
TimWolla merged 2 commits intophp:PHP-8.2from Mar 13, 2024
Merged
random: Initialize the mode field when seeding in php_random_default_status()#13690TimWolla merged 2 commits intophp:PHP-8.2from
mode field when seeding in php_random_default_status()#13690TimWolla merged 2 commits intophp:PHP-8.2from
Conversation
…lt_status()` (php#13608) This is not just an issue due to missing initialization since moving the state struct directly into the module globals. In earlier versions changing the mode to `MT_RAND_PHP` within a single request would also affect the mode for subsequent requests. Original commit message follows: This is a follow-up fix for phpGH-13579. The issue was detected in the nightly MSAN build. (cherry picked from commit bf0abd1)
zeriyoshi
approved these changes
Mar 13, 2024
TimWolla
added a commit
that referenced
this pull request
Mar 13, 2024
* PHP-8.2: random: Initialize the `mode` field when seeding in `php_random_default_status()` (#13690)
TimWolla
added a commit
that referenced
this pull request
Mar 13, 2024
* PHP-8.3: random: Initialize the `mode` field when seeding in `php_random_default_status()` (#13690)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately this is not really testable, as the used mode is not externally observable.
This is not just an issue due to missing initialization since moving the state struct directly into the module globals. In earlier versions changing the mode to
MT_RAND_PHPwithin a single request would also affect the mode for subsequent requests.Original commit message follows:
This is a follow-up fix for GH-13579. The issue was detected in the nightly MSAN build.
(cherry picked from commit bf0abd1)