Fix erroneous dnl appended in configure#14013
Merged
petk merged 2 commits intophp:PHP-8.2from Apr 21, 2024
Merged
Conversation
This is a backport of commit 03f1553 to PHP-8.2 due to phpGH-14002 and fixes the PHP_CXX_COMPILE_STDCXX check in ext/intl whether the specified C++ standard is mandatory or optional. The `dnl` (Discard to Next Line) M4 macro in this combination of `m4_if` macros and arguments isn't properly replaced and a literal `dnl` string is appended in the configure script. The `[]dnl` works ok.
devnexen
approved these changes
Apr 20, 2024
Member
Author
|
In the appended commit, I've added a note in NEWS file. |
petk
added a commit
that referenced
this pull request
Apr 21, 2024
* PHP-8.2: Fix erroneous dnl appended in configure (#14013)
petk
added a commit
that referenced
this pull request
Apr 21, 2024
* PHP-8.3: Fix erroneous dnl appended in configure (#14013)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of commit 03f1553 to PHP-8.2 due to GH-14002 and fixes the PHP_CXX_COMPILE_STDCXX check in ext/intl whether the specified C++ standard is mandatory or optional.
The
dnl(Discard to Next Line) M4 macro in this combination ofm4_ifmacros and arguments isn't properly replaced and a literaldnlstring is appended in the configure script. The[]dnlworks ok.The configure script diff before and after: