Autotools: fix configure check for aarch64 CRC32 API#15587
Closed
bkuhls wants to merge 1 commit intophp:masterfrom
bkuhls:master_fix_arm_crc32
Closed
Autotools: fix configure check for aarch64 CRC32 API#15587bkuhls wants to merge 1 commit intophp:masterfrom bkuhls:master_fix_arm_crc32
bkuhls wants to merge 1 commit intophp:masterfrom
bkuhls:master_fix_arm_crc32
Conversation
On arm32 bit the check succeeds leading to a build error later on:
/home/autobuild/autobuild/instance-3/output-1/build/php-8.3.10/ext/standard/crc32.c:70:12:
error: 'armv8-a' does not support feature 'nothing'
70 | # pragma GCC target ("+nothing+crc")
Co-authored-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
[http://lists.busybox.net/pipermail/buildroot/2024-August/761151.html]
Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
Member
|
Thanks for sending the patch. Would you like to see this in the PHP-8.2 branch also or is the upcoming PHP-8.4 enough? |
Contributor
Author
|
Yes, besides 8.3 the 8.2 branch also needs the fix, see "end log" of the buildroot autobuilder protocols: http://autobuild.buildroot.net/?reason=php-8.2.16 |
petk
approved these changes
Aug 25, 2024
petk
added a commit
that referenced
this pull request
Aug 25, 2024
* PHP-8.2: Fix GH-15587: Autotools: fix configure check for aarch64 CRC32 API
petk
added a commit
that referenced
this pull request
Aug 25, 2024
* PHP-8.3: Fix GH-15587: Autotools: fix configure check for aarch64 CRC32 API
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On arm 32 bit the check succeeds leading to a build error later on:
/home/autobuild/autobuild/instance-3/output-1/build/php-8.3.10/ext/standard/crc32.c:70:12:
error: 'armv8-a' does not support feature 'nothing'
70 | # pragma GCC target ("+nothing+crc")