Fixed GH-18458: Authorization set with CURLOPT_USERPWD with NULL va…#18460
Closed
devnexen wants to merge 4 commits intophp:PHP-8.3from
Closed
Fixed GH-18458: Authorization set with CURLOPT_USERPWD with NULL va…#18460devnexen wants to merge 4 commits intophp:PHP-8.3from
Authorization set with CURLOPT_USERPWD with NULL va…#18460devnexen wants to merge 4 commits intophp:PHP-8.3from
Conversation
Member
|
The code seems right. Did you also check what other options, besides the 2 mentioned in the issue, need this treatment? |
Member
Author
|
likely a few more, I ll check later. |
ndossche
approved these changes
May 2, 2025
ext/curl/tests/gh18458.phpt
Outdated
| @@ -0,0 +1,33 @@ | |||
| --TEST-- | |||
| GH-18458 authorization header is set despite CURLOPT_USERPWD set to null | |||
Member
There was a problem hiding this comment.
Suggested change
| GH-18458 authorization header is set despite CURLOPT_USERPWD set to null | |
| GH-18458 (authorization header is set despite CURLOPT_USERPWD set to null) |
and add CURLOPT_PASSWORD to the mix. CURLOPT_XOAUTH2_BEARER already handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lue.