fix: Add JVM metric loaders to SimpleStrategy metrics list

myutex-developers · myutex-developers · commit 9f1d06b9c4f9 · 2025-06-16T04:49:19.000+09:00
- Add MaxJVMMemoryLoader and JVMMemoryAmountLoader to metrics property
- Fix KeyError when processing JVM workloads
- Resolve unused import warnings for JVM metric loaders

This change ensures that JVM-specific metrics are properly collected
when a JVM application is detected, preventing runtime KeyError exceptions
in __calculate_memory_proposal method.
diff --git a/robusta_krr/strategies/simple.py b/robusta_krr/strategies/simple.py
@@ -91,6 +91,8 @@ def metrics(self) -> list[type[PrometheusMetric]]:
             CPUAmountLoader,
             MemoryAmountLoader,
             JVMDetector,
+            MaxJVMMemoryLoader,
+            JVMMemoryAmountLoader,
         ]
 
         if self.settings.use_oomkill_data:

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,8 @@ def metrics(self) -> list[type[PrometheusMetric]]:`
`91`	`91`	`CPUAmountLoader,`
`92`	`92`	`MemoryAmountLoader,`
`93`	`93`	`JVMDetector,`
	`94`	`+ MaxJVMMemoryLoader,`
	`95`	`+ JVMMemoryAmountLoader,`
`94`	`96`	`]`
`95`	`97`
`96`	`98`	`if self.settings.use_oomkill_data:`