Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solidusio/solidus_auth_devise
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.5.8
Choose a base ref
...
head repository: solidusio/solidus_auth_devise
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.5.9
Choose a head ref
  • 15 commits
  • 14 files changed
  • 6 contributors

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    4843eee View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Merge pull request #245 from solidusio/waiting-for-dev/solidus_main

    Adapt to new Solidus default branch name
    waiting-for-dev authored May 22, 2023
    Configuration menu
    Copy the full SHA
    b3e431c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Ensure the admin sign in root path fallback is '/admin'

    Previously relied on solidus_frontend defining `spree.root_path`, and
    used it redirecting admin users to the store home page.
    elia committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    fde22eb View commit details
    Browse the repository at this point in the history
  2. Fix some rubocop issues

    elia committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    7bd486f View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Merge pull request #246 from solidusio/elia/admin-root-path

    Ensure the admin sign in root path fallback is '/admin'
    elia authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    cdfa866 View commit details
    Browse the repository at this point in the history
  2. Merge tag 'v2.5.8'

    Version 2.5.8
    
    * tag 'v2.5.8':
      Release v2.5.8
    elia committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e82adb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Configuration menu
    Copy the full SHA
    d46e342 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #247 from solidusio/waiting-for-dev/rename_to_main

    Adapt to the new default branch name of `main`
    waiting-for-dev authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    6bcc8d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Fix admin logout feature spec

    Update the admin logout feature spec to accommodate the UI changes 
    in the admin navigation bar.
    The 'Logout' link is now nested within a 'details' tag and must
    be clicked/expanded to access the logout functionality.
    rainerdema committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3f2a2fd View commit details
    Browse the repository at this point in the history
  2. Fix RuboCop offense in warden initializer

    ```
    config/initializers/warden.rb:7:99: C: [Correctable] Rails/FindEach: Use find_each instead of each.
    ```
    rainerdema committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3534fd0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #249 from solidusio/rainerd/fix-logout-test-post-n…

    …avbar-update
    
    Fix failing spec for admin logout
    rainerdema authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    89c8d1b View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Add empty :new action to Spree::UsersController

    Without this, specs fail with
    ```
    AbstractController::ActionNotFound:
            The new action could not be found for the :authorize_actions
            callback on Spree::UsersController, but it is listed in the controller's
            :only option.
    ```
    
    I guess this is because the views are not in the standard place, thus
    impeding Rails' ability to dynamically generate empty actions if
    matching views are present. Anyways: This is good, because it's more
    explicit.
    mamhoff committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4faf85b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Rubocop fix

    mamhoff committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1ffd9de View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge pull request #250 from mamhoff/fix-rails-7-1-specs

    [Rails 7.1] Add empty :new action to Spree::UsersController
    kennyadsl authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e7863f6 View commit details
    Browse the repository at this point in the history
  2. Release v2.5.9

    spaghetticode committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9f25007 View commit details
    Browse the repository at this point in the history
Loading