mozilla AST output: correctly input and output object keys with quotes

fabiosantoscode · fabiosantoscode · commit cb612a2505ff · 2025-05-26T15:25:47.000+01:00
diff --git a/lib/mozilla-ast.js b/lib/mozilla-ast.js
@@ -355,6 +355,9 @@ import { is_basic_identifier_string } from "./parse.js";
                 start    : my_start_token(key || M.value),
                 end      : my_end_token(M.value),
                 key      : key.type == "Identifier" ? key.name : key.value,
+                quote    : !key.computed && key.type === "Literal" && typeof key.value === "string"
+                            ? '"'
+                            : null,
                 value    : from_moz(M.value)
             };
             if (M.computed) {
@@ -387,7 +390,6 @@ import { is_basic_identifier_string } from "./parse.js";
             if (M.kind == "method") {
                 args.async = M.value.async;
                 args.is_generator = M.value.generator;
-                args.quote = M.computed ? "\"" : null;
                 return new AST_ConciseMethod(args);
             }
         },
@@ -1595,7 +1597,7 @@ import { is_basic_identifier_string } from "./parse.js";
     def_to_moz(AST_ObjectProperty, function To_Moz_Property(M, parent) {
         var key = M.key instanceof AST_Node ? to_moz(M.key) : {
             type: "Identifier",
-            value: M.key
+            value: M.key,
         };
         if (typeof M.key === "number") {
             key = {
@@ -1604,10 +1606,16 @@ import { is_basic_identifier_string } from "./parse.js";
             };
         }
         if (typeof M.key === "string") {
-            key = {
-                type: "Identifier",
-                name: M.key
-            };
+            key = M.quote
+                ? {
+                    type: "Literal",
+                    value: M.key,
+                    raw: JSON.stringify(M.key),
+                }
+                : {
+                    type: "Identifier",
+                    name: M.key,
+                };
         }
         var kind;
         var string_or_num = typeof M.key === "string" || typeof M.key === "number";
diff --git a/test/input/spidermonkey/input.js b/test/input/spidermonkey/input.js
@@ -165,6 +165,9 @@ var a = {
     get "five"() {
         return 5;
     },
+    get ""() {
+        return "";
+    },
     set one(value) {
         this._one = value;
     },
@@ -177,13 +180,20 @@ var a = {
     set "eleven"(value) {
         this._eleven = value;
     },
+    set ""(value) {
+        this[""] = value
+    },
     *"%"() {
         return 2;
     },
     *["%"]() {
         return 2;
     },
-    [a]() {}
+    a() {},
+    [a]() {},
+    "": a,
+    ""() { },
+    "a": a,
 };
 
 // RegExp literals
