Fix per-element allow list handling.#57591
Draft
jonathan-j-lee wants to merge 1 commit intoweb-platform-tests:masterfrom
Draft
Fix per-element allow list handling.#57591jonathan-j-lee wants to merge 1 commit intoweb-platform-tests:masterfrom
jonathan-j-lee wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
RemoveAttribute doesn't remove per-element allow list attributes (when there's also a global allow list). This is per (old) spec, but the spec has been fixed. Add CHECKs for Sanitizer's primary security guarantee, to make sure similar issues will not result in an unsafe user experience. Spec: WICG/sanitizer-api#369 Bug: 477643913, 479513763 Change-Id: I60a103f3fea6ad01f2090a13400e1d51941bea11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7516493 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1579985}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveAttribute doesn't remove per-element allow list attributes (when there's also a global allow list). This is per (old) spec, but the spec has been fixed.
Add CHECKs for Sanitizer's primary security guarantee, to make sure similar issues will not result in an unsafe user experience.
Spec: WICG/sanitizer-api#369
Bug: 477643913, 479513763
Change-Id: I60a103f3fea6ad01f2090a13400e1d51941bea11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7516493
Reviewed-by: Mike West mkwst@chromium.org
Commit-Queue: Daniel Vogelheim vogelheim@chromium.org
Cr-Commit-Position: refs/heads/main@{#1579985}