devtools/cmd/seeddb: apply -keep_going to versions check

Some module proxies may return invalid responses for versions for some modules.
This change helps skip through those, when the majority of other modules would
succeed.

Concrete example: given a GitHub repo with no tagged releases, when querying
the official Go module proxy for versions at /v@/list, it returns 200 OK and no
content (since there are no versions). The jFrog Artifactory go module proxy's
behaviour, in contrast, is to return 404 NOT FOUND if there are no versions.

That means that if you're using seeddb and any of your seed.txt modules does
not have tagged versions, we fail-fast when we try to list that module's
versions, despite using -keep_going. This change applies -keep_going to that
section of code, so that we skip over the 404 errors.

Original author: Jean Barkhuysen <[email protected]>

Fixes #71140

Change-Id: I2ccbcc356c322deed81860ee92274fba04a079b2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/641675
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
kokoro-CI: kokoro <[email protected]>
Reviewed-by: Jean Barkhuysen <[email protected]>
1 file changed
tree: 6cfa6e7705cb19b4a7d2de128b42678fe16c99bd
  1. .github/
  2. cmd/
  3. deploy/
  4. devtools/
  5. doc/
  6. internal/
  7. migrations/
  8. static/
  9. tests/
  10. third_party/
  11. .dockerignore
  12. .eslintignore
  13. .eslintrc.yaml
  14. .gitignore
  15. .prettierignore
  16. .prettierrc.yaml
  17. .stylelintignore
  18. .stylelintrc.yaml
  19. all.bash
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. jest.config.js
  24. LICENSE
  25. package-lock.json
  26. package.json
  27. PATENTS
  28. README.md
  29. tsconfig.json
README.md

golang.org/x/pkgsite

This repository hosts the source code of the pkg.go.dev website, and pkgsite, a documentation server program.

Go Reference

pkg.go.dev: a site for discovering Go packages

Pkg.go.dev is a website for discovering and evaluating Go packages and modules.

You can check it out at https://pkg.go.dev.

pkgsite: a documentation server

pkgsite program extracts and generates documentation for Go projects.

Example usage:

$ go install golang.org/x/pkgsite/cmd/pkgsite@latest
$ cd myproject
$ pkgsite -open .

For more information, see the pkgsite documentation.

Requirements

Pkgsite requires Go 1.19 to run. The last commit that works with Go 1.18 is 9ffe8b928e4fbd3ff7dcf984254629a47f8b6e63. The last commit that works with Go 1.17 is 4d836c6a652cde92f433967680dfd6171a91ec12.

Issues

If you want to report a bug or have a feature suggestion, please first check the known issues to see if your issue is already being discussed. If an issue does not already exist, feel free to file an issue.

For answers to frequently asked questions, see pkg.go.dev/about.

You can also chat with us on the #pkgsite Slack channel on the Gophers Slack.

Contributing

We would love your help!

Our canonical Git repository is located at go.googlesource.com/pkgsite. There is a mirror of the repository at github.com/golang/pkgsite.

To contribute, please read our contributing guide.

License

Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.

Links