Skip to content

feat: add meta object to @eslint/js plugin #19095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Nov 4, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

add something to @eslint/js

closes #19091

What changes did you make? (Give an overview)

This PR adds a meta object to the @eslint/js plugin. I also updated a code example to include names for config objects. The lack of name properties was apparently a source of confusion in #19091.

Plugin meta and config name properties are optional but recommended:

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Nov 4, 2024
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 0eda64f
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/672902cbc673060008c04210

@fasttime fasttime marked this pull request as ready for review November 4, 2024 17:26
@fasttime fasttime requested a review from a team as a code owner November 4, 2024 17:26
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like another review before merging.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 6, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @eslint/js is is currently not used as a plugin, but it doesn't hurt to add meta already.

@mdjermanovic mdjermanovic merged commit 3087c9e into main Nov 6, 2024
26 checks passed
@mdjermanovic mdjermanovic deleted the eslint-js-meta branch November 6, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Change Request: Add meta and rules properties to ESLint JavaScript Plugin (@eslint/js) export
3 participants