Skip to content

feat(configs): add new severity option for all rules (#733) #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

feat(configs): add new severity option for all rules (#733) #736

merged 3 commits into from
Apr 8, 2025

Conversation

stambolievv
Copy link
Contributor

Description

This PR introduces a new severity option that allows users to configure all rules as warnings instead of errors. This helps developers reduce distractions in their IDEs while still enforcing strict rule compliance at commit time.

Linked Issues

Closes #733

Additional context

Would it be helpful to provide predefined recommended-warn and all-warn presets with warning severity? This would allow users to enable a warning-based configuration more easily without needing to use customize method.

@stambolievv stambolievv requested a review from 9romise April 7, 2025 19:24
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.54%. Comparing base (99c0873) to head (42ab4af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage   75.54%   75.54%           
=======================================
  Files         122      122           
  Lines       24456    24456           
  Branches     4670     4670           
=======================================
  Hits        18476    18476           
  Misses       5980     5980           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antfu antfu enabled auto-merge April 8, 2025 23:26
@antfu antfu added this pull request to the merge queue Apr 8, 2025
Merged via the queue into eslint-stylistic:main with commit c553a9c Apr 8, 2025
11 checks passed
@Martinspire
Copy link

Martinspire commented May 27, 2025

Personally I think this warranted a major version update. One of the reasons my configs are big, is because I override most rules to warn, or use the eslint only-warn plugin. But this is a neat change that will help out a lot of people. Perhaps its something that could be mentioned in the release notes for the next version in case it flew under the radar for some folks. Als already mentioned previously, I feel that stylistic problems should always be warnings and perhaps it can be the default, but overall its nice that we can now configure it globally. Nicely done on this new feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to change severity of the rules
4 participants