refactor: add reusable Cleaner API
#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
force-pushed
the
add-cleaner
branch
4 times, most recently
from
b49f7a8 to
1c2cc07
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a reusable Cleaner API that allows users to configure HTML sanitization options once and reuse them for multiple cleaning operations, rather than having to specify all options for each individual clean() call.
- Adds a new
Cleanerstruct that holds pre-configured sanitization settings - Refactors the existing
clean()function to use the newCleanerinternally - Introduces self-referencing pattern using the
ouroboroscrate to manage lifetime dependencies
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/lib.rs | Implements the main Cleaner struct with configuration management and refactors the existing clean function |
| nh3.pyi | Adds Python type hints for the new Cleaner class |
| Cargo.toml | Adds ouroboros dependency for self-referencing struct support |
| }); | ||
|
|
||
| Ok(cleaned) | ||
| let cleaner = Cleaner::py_new( |
There was a problem hiding this comment.
Creating a new Cleaner instance for each call to the clean function defeats the purpose of having a reusable cleaner and impacts performance. Consider using a static default cleaner for cases where all parameters match defaults.
Copilot uses AI. Check for mistakes.
ColdHeat
added a commit
to CTFd/CTFd
that referenced
this pull request
Jul 24, 2025
* Update nh3 to 0.3.0 * Use the added Cleaner.clean interface added to nh3 (messense/nh3#90) * Add tests from the pybluemonday repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.