Skip to content

Added KeySet Pagination for Gitlab Projects V2 Enumeration #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2025
Merged

Added KeySet Pagination for Gitlab Projects V2 Enumeration #4319

merged 5 commits into from
Jul 17, 2025

Conversation

kashifkhan0771
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 commented Jul 16, 2025 •
edited
Loading

Description:

This Pull Request introduces keyset pagination for GitLab project enumeration, building on the simplified enumeration approach from #4283.
Key Changes:

  • Implements keyset-based pagination using GitLab's Scan2 method for automatic pagination handling
  • Replaces traditional offset-based pagination with more efficient keyset pagination
  • Improves performance and reliability for large GitLab instances

Important Note:
The Scan2 API is currently experimental and may introduce breaking changes in future GitLab client releases. We should monitor for API changes when updating the GitLab client dependency.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@kashifkhan0771 kashifkhan0771 requested review from a team as code owners July 16, 2025 08:01
rosecodym
rosecodym reviewed Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I have some small notes about naming but nothing about the logic.

rosecodym
rosecodym reviewed Jul 16, 2025
View reviewed changes
rosecodym
rosecodym approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for turning this around so quickly!

shahzadhaider1
shahzadhaider1 approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@shahzadhaider1 shahzadhaider1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GW

@kashifkhan0771 kashifkhan0771 merged commit 7792f02 into trufflesecurity:main Jul 17, 2025
13 checks passed
@kashifkhan0771 kashifkhan0771 deleted the update/oss-261 branch July 17, 2025 05:57
@blsaccess blsaccess mentioned this pull request Jul 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosecodym rosecodym rosecodym approved these changes

@shahzadhaider1 shahzadhaider1 shahzadhaider1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kashifkhan0771 @rosecodym @shahzadhaider1