fix(ssr): fix execution order of re-export #19841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ecosystem-ci run |
commit: |
This comment was marked as outdated.
This comment was marked as outdated.
|
📝 Ran ecosystem CI on
✅ ladle, astro, analogjs, histoire, marko, nuxt, qwik, vite-plugin-cloudflare, vite-plugin-pwa, rakkas, vite-plugin-react-swc, unocss, previewjs, vite-plugin-svelte, vite-plugin-vue, sveltekit, quasar, react-router, vite-plugin-react, vite-setup-catalogue, vitest, vitepress, vuepress |
sapphi-red
added
feat: ssr
p2-edge-case
sapphi-red
previously approved these changes
Apr 15, 2025
6 tasks
sapphi-red
approved these changes
Apr 23, 2025
This was referenced May 2, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently re-export's
__vite_ssr_import__position is preserved at the original code as it usesdefineImport(node.start, ...). I replaced it withdefineImport(hoistIndex, ...), so they'll get hoisted in the same way as normal imports.This fixes the test case added in #14468 as seen in the snapshot diff.
Additional note: rollup and rolldown's execution order likely work in the same way