Adds dependency declarations to order tasks#237
Merged
punya merged 1 commit intoGoogleCloudPlatform:mainfrom May 5, 2023
Merged
Adds dependency declarations to order tasks#237punya merged 1 commit intoGoogleCloudPlatform:mainfrom
punya merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
The missing dependency declarations result in errors in the release tasks - pointing to possibility of incorrect result depending on order in which these tasks execute. The release tasks are skipped during normal :build jobs so build passes, but the artifacts snapshot generation for release fails.
Contributor
Author
|
Not sure why this was not an issue in the previous release, but the shading process for shared-resourcemapping module was altered a little after the last release was made and gradle plugin version was updated too. |
punya
approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing dependency declarations result in errors in the release tasks - pointing to possibility of incorrect result depending on order in which these tasks execute.
The release tasks are skipped during normal :build jobs so build passes, but the artifacts snapshot generation for release fails.
Supports #215