Fix addSarifExtension and add tests

mbg · mbg · commit 603a57277239 · 2025-09-01T16:17:25.000+01:00
diff --git a/lib/analyze-action.js b/lib/analyze-action.js
diff --git a/src/analyze.test.ts b/src/analyze.test.ts
@@ -5,11 +5,13 @@ import test from "ava";
 import * as sinon from "sinon";
 
 import * as actionsUtil from "./actions-util";
+import { CodeQuality, CodeScanning } from "./analyses";
 import {
   exportedForTesting,
   runQueries,
   defaultSuites,
   resolveQuerySuiteAlias,
+  addSarifExtension,
 } from "./analyze";
 import { createStubCodeQL } from "./codeql";
 import { Feature } from "./feature-flags";
@@ -348,3 +350,13 @@ test("resolveQuerySuiteAlias", (t) => {
     t.deepEqual(resolveQuerySuiteAlias(KnownLanguage.go, name), name);
   }
 });
+
+test("addSarifExtension", (t) => {
+  for (const language of Object.values(KnownLanguage)) {
+    t.deepEqual(addSarifExtension(CodeScanning, language), `${language}.sarif`);
+    t.deepEqual(
+      addSarifExtension(CodeQuality, language),
+      `${language}.quality.sarif`,
+    );
+  }
+});
diff --git a/src/analyze.ts b/src/analyze.ts
@@ -615,7 +615,7 @@ export function addSarifExtension(
   analysis: analyses.AnalysisConfig,
   base: string,
 ): string {
-  return `${base}.${analysis.sarifExtension}`;
+  return `${base}${analysis.sarifExtension}`;
 }
 
 // Runs queries and creates sarif files in the given folder

Original file line number	Diff line number	Diff line change
`@@ -615,7 +615,7 @@ export function addSarifExtension(`
`615`	`615`	`analysis: analyses.AnalysisConfig,`
`616`	`616`	`base: string,`
`617`	`617`	`): string {`
`618`		- return `${base}.${analysis.sarifExtension}`;
	`618`	+ return `${base}${analysis.sarifExtension}`;
`619`	`619`	`}`
`620`	`620`
`621`	`621`	`// Runs queries and creates sarif files in the given folder`