UnnecessarilyFullyQualified: handle java.lang and inconsistent import usages#2776
Closed
rickie wants to merge 1 commit intogoogle:masterfrom
Closed
UnnecessarilyFullyQualified: handle java.lang and inconsistent import usages#2776rickie wants to merge 1 commit intogoogle:masterfrom
java.lang and inconsistent import usages#2776rickie wants to merge 1 commit intogoogle:masterfrom
Conversation
Stephan202
approved these changes
Dec 23, 2021
Contributor
Stephan202
left a comment
Stephan202
left a comment
There was a problem hiding this comment.
Tested against the Picnic code base with positive results 👍
cushon
approved these changes
Dec 23, 2021
Stephan202
force-pushed
the
rossendrijver/java_lang_qualified
branch
from
8051af2 to
1dae0db
Compare
Contributor
|
Rebased the branch so that the JDK 18-ea build now passes. (IIUC @cushon's approval already caused a Google-internal PR to be opened, so this is mostly for bookkeeping purposes.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces two improvements:
java.lang.SomeTypereferences are simplified toSomeTypewithout introducing an associated
importstatement.some.package.SomeTypeare now also replaced withSomeTypeif said type is already imported and referenced by its simple name elsewhere
in the compilation unit.