fix(jdbc): return null for invalid URLs in connect() to comply with JDBC spec (#4086)

keshavdandeva · web-flow · commit 0c030d06fe43 · 2026-02-02T18:53:36.000+01:00
diff --git a/google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDriver.java b/google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDriver.java
@@ -165,8 +165,7 @@ public Connection connect(String url, Properties info) throws SQLException {
                 this.toString()));
         return connection;
       } else {
-        throw new IllegalArgumentException(
-            "Invalid URL provided, must start with \"jdbc:bigquery:\"");
+        return null;
       }
     } catch (IOException e) {
       LOG.warning("Getting a warning: " + e.getMessage());
diff --git a/google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryDriverTest.java b/google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryDriverTest.java
@@ -16,7 +16,6 @@
 package com.google.cloud.bigquery.jdbc;
 
 import static com.google.common.truth.Truth.assertThat;
-import static org.junit.Assert.assertThrows;
 
 import java.sql.Connection;
 import java.sql.DriverPropertyInfo;
@@ -36,8 +35,8 @@ public void setUp() {
   }
 
   @Test
-  public void testInvalidURLDoesNotConnect() {
-    assertThrows(IllegalArgumentException.class, () -> bigQueryDriver.connect("badURL.com", null));
+  public void testInvalidURLReturnsNull() throws SQLException {
+    assertThat(bigQueryDriver.connect("badURL.com", null)).isNull();
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@`
`16`	`16`	`package com.google.cloud.bigquery.jdbc;`
`17`	`17`
`18`	`18`	`import static com.google.common.truth.Truth.assertThat;`
`19`		`-import static org.junit.Assert.assertThrows;`
`20`	`19`
`21`	`20`	`import java.sql.Connection;`
`22`	`21`	`import java.sql.DriverPropertyInfo;`
`@@ -36,8 +35,8 @@ public void setUp() {`
`36`	`35`	`}`
`37`	`36`
`38`	`37`	`@Test`
`39`		`- public void testInvalidURLDoesNotConnect() {`
`40`		`- assertThrows(IllegalArgumentException.class, () -> bigQueryDriver.connect("badURL.com", null));`
	`38`	`+ public void testInvalidURLReturnsNull() throws SQLException {`
	`39`	`+ assertThat(bigQueryDriver.connect("badURL.com", null)).isNull();`
`41`	`40`	`}`
`42`	`41`
`43`	`42`	`@Test`