core: preserve KnownLength when wrapping InputStream#6852
Merged
zhangkun83 merged 1 commit intogrpc:masterfrom Mar 30, 2020
Merged
core: preserve KnownLength when wrapping InputStream#6852zhangkun83 merged 1 commit intogrpc:masterfrom
zhangkun83 merged 1 commit intogrpc:masterfrom
Conversation
|
|
Member
|
In places we check for KnownLength we try to check for ByteArrayInputStream as well, explicitly. It seems that is missing in ProtoLiteUtils. We should just fix it to be (Alternatively we could have a |
Member
|
Oh, I see. This is BufferedInputStream |
ejona86
approved these changes
Mar 24, 2020
useInputStreamMessages ensures that the InputStream supports marking by wrapping the stream in a BufferedInputStream if markSupported() returns false. This change uses a new subclass of BufferedInputStream that also implements KnownLength, when the original stream also implements KnownLength.
zhangkun83
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
useInputStreamMessages ensures that the InputStream supports marking by wrapping the stream in a BufferedInputStream if markSupported() returns false. This change uses a new subclass of BufferedInputStream that also implements KnownLength, when the original stream also implements KnownLength.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useInputStreamMessages ensures that the InputStream supports marking by wrapping the stream in a BufferedInputStream if markSupported() returns false. This change uses a new subclass of BufferedInputStream that also implements KnownLength, when the original stream also implements KnownLength.