Add a proto_lang_toolchain for javalite#6882
Merged
rafi-kamal merged 3 commits intoprotocolbuffers:masterfrom Nov 27, 2019
Merged
Add a proto_lang_toolchain for javalite#6882rafi-kamal merged 3 commits intoprotocolbuffers:masterfrom
rafi-kamal merged 3 commits intoprotocolbuffers:masterfrom
Conversation
Contributor
Author
|
@ejona86 do you know how can I test it? Is there a |
Contributor
|
It looks like your examples include a java_lite_proto_library :) Lines 73 to 76 in 4e93585 (And I only know this because of the build failure you mentioned in #6898) That means you should also update it's workspace to use a Lines 24 to 28 in 4e93585 |
ejona86
approved these changes
Nov 27, 2019
Contributor
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
I fixed a bug and updated the examples, but now it is running for me. You can test by cd examples/; bazel build :addressbook_java_lite_proto
Contributor
Author
|
Thank you very much :) |
ejona86
pushed a commit
to ejona86/protobuf
that referenced
this pull request
Dec 3, 2019
* Add a proto_lang_toolchain for javalite * fix toolchain. Swap javalite example to master repo
rafi-kamal
pushed a commit
that referenced
this pull request
Dec 3, 2019
nlhien
pushed a commit
to nlhien/protobuf
that referenced
this pull request
Feb 28, 2020
* Add a proto_lang_toolchain for javalite * fix toolchain. Swap javalite example to master repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that javalite can be used from Bazel. Related discussion: #6867