Added UnsafeByteOperations to protobuf-lite#8426
Merged
perezd merged 1 commit intoprotocolbuffers:masterfrom Mar 24, 2021
Merged
Added UnsafeByteOperations to protobuf-lite#8426perezd merged 1 commit intoprotocolbuffers:masterfrom
perezd merged 1 commit intoprotocolbuffers:masterfrom
Conversation
Contributor
|
PTAL at the Mergable error: ❌ (((Please include release notes: yes AND Please include at least a language label (e.g., c++, java, python). Or apply one of the following labels: autotools, bazel, cmake, cleanup, conformance tests, integration, protoc.) OR Please include release notes: no)) |
Contributor
|
Actually, my fault I can do this! |
Contributor
Author
|
@perezd Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
UnsafeByteOperationstoprotobuf-lite.UnsafeByteOperationsis needed for gRPC Java which relies onprotobuf-liteto wrap a ByteBuffer when creating a ByteString.UnsafeByteOperationsis a pretty small class so it won't increase the footprint ofprotobuf-litemuch.