Skip to content

Fix declared dependencies from merge issue#291

Merged
chingor13 merged 1 commit intogoogleapis:masterfrom
chingor13:fix-dep
Jul 11, 2019
Merged

Fix declared dependencies from merge issue#291
chingor13 merged 1 commit intogoogleapis:masterfrom
chingor13:fix-dep

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jul 9, 2019

This direct dependency was added in #288, but the presubmit check was not yet set up. It was already being transitively pulled in via google-auth-library-oauth2-http

@chingor13 chingor13 requested a review from a team July 9, 2019 22:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2019
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9b14268). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #291   +/-   ##
=========================================
  Coverage          ?   78.79%           
  Complexity        ?      340           
=========================================
  Files             ?       21           
  Lines             ?     1495           
  Branches          ?      162           
=========================================
  Hits              ?     1178           
  Misses            ?      238           
  Partials          ?       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b14268...6a02c42. Read the comment docs.

@chingor13 chingor13 merged commit 35abf13 into googleapis:master Jul 11, 2019
@chingor13 chingor13 deleted the fix-dep branch July 11, 2019 15:50
bcoe pushed a commit to bcoe/google-auth-library-java that referenced this pull request Jul 26, 2019
@chingor13 chingor13 added the fix label Jul 26, 2019
bcoe pushed a commit to bcoe/google-auth-library-java that referenced this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants