Merged
Conversation
@suztomo It's not immediatley obvious to me why the autoupdate didn't catch this, but mayber there's a configuration issue somewhere?
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
============================================
- Coverage 79.67% 79.63% -0.04%
Complexity 389 389
============================================
Files 27 27
Lines 1761 1758 -3
Branches 183 181 -2
============================================
- Hits 1403 1400 -3
Misses 262 262
Partials 96 96
Continue to review full report at Codecov.
|
chingor13
approved these changes
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chingor13 It's not immediately obvious to me why the autoupdate didn't catch this, but maybe there's a configuration issue somewhere?
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)