feat: support reading in quotaProjectId for billing#383
Merged
codyoss merged 10 commits intogoogleapis:masterfrom Dec 13, 2019
Merged
feat: support reading in quotaProjectId for billing#383codyoss merged 10 commits intogoogleapis:masterfrom
codyoss merged 10 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
codyoss
force-pushed
the
quota-project
branch
from
c9c1f7b to
1a760d6
Compare
codyoss
force-pushed
the
quota-project
branch
from
1a760d6 to
40ce4a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
============================================
- Coverage 79.63% 79.53% -0.11%
- Complexity 389 397 +8
============================================
Files 27 27
Lines 1758 1803 +45
Branches 181 188 +7
============================================
+ Hits 1400 1434 +34
- Misses 262 269 +7
- Partials 96 100 +4
Continue to review full report at Codecov.
|
elharo
reviewed
Dec 10, 2019
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ServiceAccountCredentialsTest.java
Outdated
Show resolved
Hide resolved
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This was referenced Dec 11, 2019
chingor13
reviewed
Dec 12, 2019
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ServiceAccountCredentialsTest.java
Show resolved
Hide resolved
chingor13
requested changes
Dec 12, 2019
| * @return New ServiceAccountJwtAcceessCredentials created from a private key. | ||
| * @throws IOException if the credential cannot be created from the private key. | ||
| */ | ||
| public static ServiceAccountJwtAccessCredentials fromPkcs8( |
Contributor
There was a problem hiding this comment.
This one is also unnecessary
Contributor
There was a problem hiding this comment.
Is this one actually needed?
Member
Author
There was a problem hiding this comment.
I would say yes actually for this one. I moved it to package scope though as to not expose more surface to the api.
chingor13
approved these changes
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.