Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
[Blink] Call PaintRenderingResultsToSnapshot() for Canvas2D
HTMLCanvasElement currently has a Canvas2D-specific flow that gets a
snapshot via:
snapshot = null;
if (context has valid CRP) {
snapshot = context->GetImage();
}
Given the implementation of CanvasRenderingContext2D::GetImage() [1]
and the fact that the context having a valid CRP means that it cannot
be in hibernation, this is the following:
snapshot = null;
if (context has valid CRP) {
provider = context->provider;
provider->FlushCanvas(reason);
provider->Snapshot(reason);
}
By design, this is precisely the semantics of
PaintRenderingResultsToSnapshot() [2]. Hence, we can replace this block
with a call to that method.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6802285
[2] https://chromium-review.googlesource.com/c/chromium/src/+/6802903
Bug: 352263194
Change-Id: I64509565d37fc9ca40073d93ad89a91896a051b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6805454
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495272}
[getDisplayMedia] Add virtual suite for RestrictOwnAudio
Bug: 415952276
Change-Id: Ib9072660aef4074dc0662e65ffbb0c36b3966e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6802811
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495271}
[Blink] Adjust BaseRC2D::PaintToSnapshot() semantics
This CL aligns the BaseRenderingContext2D implementation of
PaintRenderingResultsToSnapshot() with that of other implementations
that ensure that the canvas contents are up to date before taking a
snapshot. This CL also changes it to return nullptr in the case where
the provider isn't valid to align with
CanvasRenderingContext2D::GetImage() semantics.
These changes will enable it to be used in a followup CL. There are
no current calls to this method for 2D canvas [1], so this CL itself
is a no-op.
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h;l=213;bpv=1;bpt=1?q=CanvasRenderingContext&ss=chromium
Bug: 352263194
Change-Id: I0a4b2b24b3029d3ad5fbdf1d74c5489ebe95885a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6802903
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495270}
Roll Chrome Android ARM64 Orderfile from uRQuvWsAmMB-ShOdg... to I6JsLRt3BXMcFWgOZ...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I8327f44ce74e6c9d27e6d2afc1e1a4dbb3ab3e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809556
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495269}
[Blink] Fix CRP validity check in HTMLCanvasElement
The comment here makes clear that the intent is to check that the
context has a *valid* resource provider (the condition under which we
are guaranteed not to be in hibernation). However, the code checks only
that we have a resource provider. Fix the code to match the intended
usage.
This has the slight behavioral change that in the edge case where if
we created an invalid CRP on exiting hibernation and then painted, we
will now paint black rather than a snapshot of the page at the time of
hibernation.
Bug: 352263194
Change-Id: I892a9780a343982b9fbd4652339ea38a4ae84a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6802906
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495268}
[Blink] Streamline CanvasRenderingContext2D::GetImage()
Coalesces the checks for the resource provider being present and valid
into a single IsCanvas2DResourceProviderValid() call. There is no
functional change.
Bug: 352263194
Change-Id: Iaa79a71c30f62fc8f27e0b8da0e849db4b22ad7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6802285
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495267}
[Blink] Stop ImageBitmapRC creating bitmap CRP for offscreen canvas
ImageBitmapRenderingContext uses
`resource_provider_for_offscreen_canvas_` only to produce a
CanvasResource to serve as an offscreen canvas frame [1]. By the same
reasoning as in [2], this serves no purpose as
CanvasResourceProviderBitmap returns null from ProduceCanvasResource().
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context.cc;l=237-247;drc=5bed397406fa579d7fa13d67cfd58a0f000d8e92;bpv=1;bpt=1
[2] https://chromium-review.googlesource.com/c/chromium/src/+/6787816
Bug: 352263194
Change-Id: Ic54ac0aaa8cdbffaf1d65a632618f8dfd75b3d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6802806
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495266}
[Blink] Have CanvasRenderingContext2D::GetImage not call GetOrCreateCRP
`resource_provider_` is guaranteed to be non-null here as the code is
guarded by a check on `IsPaintable()` [1] being true above. Hence, what
this call is actually doing is checking whether `resource_provider_` is
valid [2]. Do this directly.
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc;l=948?q=CanvasRenderingContext2D::IsPaint&ss=chromium
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc;l=1306-1319;bpv=1;bpt=0
Bug: 352263194
Change-Id: Ie390bc61448a0042112b275c2c35712561d0b84d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6805695
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495265}
mahi: fix all magic boost availability checks failure
`mahi_availability::IsMahiAvailable()` can hold three values: nullopt if
the value is missing, and `true` or `false` if the value is available.
We can only claim MahiManagerImpl::IsEnabled() to be true if the `mahi_availability::IsMahiAvailable()` has the value and
`mahi_availability::IsMahiAvailable().value() = true`.
This CL adds the missing check.
Bug: b:435542803
Change-Id: I3698bbb82640907288509f33c62edafeb97584ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809905
Reviewed-by: Thanh Nguyen <[email protected]>
Reviewed-by: Yuki Awano <[email protected]>
Commit-Queue: Chuong Ho <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495264}
[//media] Remove GMBFactory ref from platform_video_frame_pool.cc
Bug: 404905709
Change-Id: I0a3d4557b1771126e536b76aa1300e26eabed8ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6803463
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495263}
[//gpu] Remove comment from d3d_image_backing.cc
The explicit copy is indeed necessary (see discussion on [1]).
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6798803
Bug: 415968760
Change-Id: I0dbc2f7f8c9196e9481ec63493109d85e131dc0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6805451
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495262}
[//gpu] Remove unused ID from gpu_client_ids.h
Obsolete post-removal of GpuMemoryBufferId \o/.
Bug: 404905709
Change-Id: I2f7ddd4c02ce164861b23fda0025eb6c39569612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6805192
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Antonio Sartori <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495261}
[//media] Remove dead var from VideoEncoderTestEnvironment
Bug: 404905709
Change-Id: I0ad5ee52c7d7aef83003c6f247a4c6e9e5b5f797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6802901
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495260}
metal::HDRCopierLayer: Enable for all HDR layers
There was a check that only enabled HDR for SRGB_HDR, and then a recent
change (crrev.com/1493694) caused us to use the space CUSTOM_HDR.
Ideally, we should not use HDRCopierLayer, because we should be able to
make a CALayer with an IOSurface be HDR (it appears that the beta
preferredDynamicRange API might do this), without copying its contents
to a CAMetalLayer. Beyond that, we shouldn't indicate HDR-ness via
gfx::ColorSpace.
Add tests for this.
Bug: 40268540
Change-Id: I85dfad544abe80217fb309e8bec46bad8955dd0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6806965
Reviewed-by: Sunny Sachanandani <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495259}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1753984643-35a68821a6616d49a5e282df39fe0c1f455ed20c-739f10b7f26e3db54704550f0cea4efc11e28c37.profdata to chrome-win32-main-1754005981-ba7779fda3ea8a8858a410eec324f06179d65470-1472d1bc9adbbc7279d1446f0abe4e505570da8a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ife975a1d97323f6f451b2aa9d2330fc654da897a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809160
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495258}
[Autofill] Remove unused DenseSet<FormType>
Bug: 40100455
Change-Id: Idcc9983a08522bbb352284bcc0041b5f191a4697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808895
Reviewed-by: Jan Keitel <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Auto-Submit: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495257}
[OriginAPI] Introduce `Origin.fromURL()`.
This CL introduces a simple implementation of `Origin.fromURL()`, as
sketched out in https://github.com/mikewest/origin-api/.
Bug: 434131026
Change-Id: I408a29360332219fa3df18f762e1aa0b6e17f691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788082
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Antonio Sartori <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495256}
Preloading: Introduce "eager" eagerness heuristic for Desktop
This CL introduces mouse hover heuristics for the "eager" eagerness of the Speculation Rules API, enabled by the `kPreloadingEagerHeuristics` flag.
After this change, "eager" is no longer an immediate eagerness and has its own mouse hover heuristics to trigger preloading. Additionally, clicking on links also triggers preloading for the "eager" eagerness.
The remaining histogram updates will be completed in
https://crrev.com/c/6677854.
Design Doc: https://docs.google.com/document/d/1YPbtUPfZIDElzBZNx8IQMzRFvy8oauLG_i1XIr6jgTs/edit
Bug: 40287486
Change-Id: Id2fe755760cd5f64c3cc4b5fa15e815fa0de1ad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778982
Reviewed-by: Lingqi Chi <[email protected]>
Reviewed-by: Taiyo Mizuhashi <[email protected]>
Commit-Queue: Takashi Nakayama <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495255}
[webauthn] Flag guard reading cert XML serial
Chrome started reading the cert XML serial number from the enclave's PIN
wrap command. However, this feature hasn't actually landed on the
enclave yet so it causes Chrome to crash when enrolling.
Guard reading the serial number under `WebAuthenticationWrapCohortData`
and have that flag be disabled by default instead.
Bug: 399818721
Change-Id: I50ab16624d3dccda96afef52f4f50816cd685083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6807457
Reviewed-by: Adem Derinel <[email protected]>
Commit-Queue: Adem Derinel <[email protected]>
Auto-Submit: Nina Satragno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495254}
Roll Perfetto from 3e0dbdb048c8 to cab3e8dcacb6 (1 revision)
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/3e0dbdb048c8..cab3e8dcacb6
2025-08-01 77857237+[email protected] docs: clarify developer tools branch creation command (#2341)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected],[email protected]
Change-Id: I9dedf817a1ce99574472b13819e0e1c1d2604a67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809631
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495253}
Remove extraneous AddHeadersFromString calls.
Bug: 41400723
Change-Id: I5be32c70d6369772ddaf945cd6ff6a50998ba82e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6807220
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Doug Turner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495252}
Reland "[FontConfig] Switch indexing from FreeType to Fontations"
This reverts commit 6a2a52e339baa9a2a922e93bc8deb94f80803224.
Reason for revert: Test if flaky failure?
Bug: chromium:349952802
Original change's description:
> Revert "[FontConfig] Switch indexing from FreeType to Fontations"
>
> This reverts commit 165eac25480e96c4f72750bb99765fa1cea94b43.
>
> Reason for revert:
> LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8707907002952688881
>
> Sample failed build: https://ci.chromium.org/b/8707907002952688881
>
> If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6772495&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8707907002952688881&type=BUG
>
> Original change's description:
> > [FontConfig] Switch indexing from FreeType to Fontations
> >
> > Introduce a flag "FontConfigFontationsIndexing" to set the FC_FONTATIONS
> > environment variable when indexing using Fontations is
> > requested. Setting the environment variable causes a switch between
> > indexing backends, see fontconfig/src/src/fcdir.c.
> >
> > The flag is default enabled, moving FontConfig font indexing from unsafe
> > FreeType C code to memory-safe Rust code based on Fontations.
> >
> > We want to remove FreeType as a dependency from Chromium, and Blink in
> > particular. The last dependency in Blink on FreeType is in FontConfig
> > indexing. Hence, we switch over indexing to Fontations based
> > indexing. If this proves robust and stable, we will remove the flag and
> > the FreeType dependency from the Chromium build of FontConfig.
> >
> > The indexing functionality is tested in upstream to yield exactly the
> > same results as the FreeType indexing [1], for font formats that we
> > support in Chromium (TrueType, OpenType fonts) and been tested for all
> > Ubuntu font packages (> 1400 font files) and the majority of ChromeOS
> > system fonts (218 font files). This result, together with the fact that
> > in-memory cache structure does not have to be changed, means that we
> > can keep the same FontConfig cache version.
> >
> > [1] https://gitlab.freedesktop.org/fontconfig/fontconfig/-/blob/main/test/test_fontations_ft_query.py
> >
> > Bug: chromium:349952802
> > Change-Id: Iaf22bde042ceccde50050bc877d46ed85ed80fd1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6772495
> > Reviewed-by: Thomas Anderson <[email protected]>
> > Reviewed-by: Nico Weber <[email protected]>
> > Reviewed-by: Colin Blundell <[email protected]>
> > Commit-Queue: Dominik Röttsches <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1494224}
> >
>
> Bug: chromium:349952802
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I24dba56c93852dac3c0ef99cb807b932563f576d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6803140
> Owners-Override: [email protected] <[email protected]>
> Bot-Commit: [email protected] <[email protected]>
> Commit-Queue: [email protected] <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1494294}
Bug: chromium:349952802
Change-Id: Ife00210386bdb9be18aa59e040664b969ee03204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6805193
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495251}
Roll Chrome Android ARM64 Orderfile from igSgbfFUiZAaiwKZb... to uRQuvWsAmMB-ShOdg...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ic3107374b59e8f22f2da6ee6764316c91c8e2ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809548
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495250}
Roll Updater chromium_win_x86 from 2@1491020 to 2@1495030
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/updater-chromium-win-x86-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://g-issues.chromium.org/issues/new?component=1516667&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:win-updater-try-builder-rel;luci.chromium.try:linux-updater-try-builder-rel;luci.chromium.try:mac-updater-try-builder-rel;luci.chromium.try:win-updater-try-builder-rel
Tbr: [email protected]
Change-Id: I0291668efd179e500980b8388a9b57c0c87e4af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808100
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495249}
Roll DevTools Frontend from 96c7979dd12e to 0d0362ba551b (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/96c7979dd12e..0d0362ba551b
2025-08-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (trusted)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I9acc10809bd1673b5abe81c77758c8d7a1902bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809752
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495248}
Disable browser_tests WebUIContentsPreloadManagerHistoryClusterMetricTest.PreloadButNeverShow
This test seems to have been flaky for a while.
Bug: 435561866
Change-Id: I176e2232e0a5911895661839cd0fef27f2f108ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809986
Auto-Submit: François Degros <[email protected]>
Commit-Queue: François Degros <[email protected]>
Owners-Override: François Degros <[email protected]>
Reviewed-by: Wenbo Jie <[email protected]>
Commit-Queue: Wenbo Jie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495247}
Rename MINIJAIL_ERR_JAIL to MINIJAIL_ERR_SECCOMP_VIOLATION
Having the word "SECCOMP" as part of the error name makes it more
explicit and easier to find when grepping the code and the logs.
BUG=b:424206022
TEST=CQ
Change-Id: Iccb605299be9d7edfca4ec2fdb9750715fa20b1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6703178
Commit-Queue: François Degros <[email protected]>
Auto-Submit: François Degros <[email protected]>
Reviewed-by: Nigel Tao <[email protected]>
Commit-Queue: Nigel Tao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495246}
Fix generate_libcxx_headers for python 3.9
Bug: 432582032
Change-Id: I6a6a69644bf7594ad5f5cc94bf4390b8ab24143b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809945
Reviewed-by: Takuto Ikuta <[email protected]>
Commit-Queue: Matt Stark <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Auto-Submit: Matt Stark <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495245}
Add Installer attributes for GPU/CPU class.
Bug: 428039852
Change-Id: I93589eef4728c804f795f905b8df87553dad48fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6803281
Reviewed-by: Joshua Pawlicki <[email protected]>
Commit-Queue: Steven Holte <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495244}
[DX12 Enc] Set coded size alignment to 2 for D3D12 VEA.
H.264 requires coded size to be 2-aligned. By spec H.265 allows odd
coded size but this adds complexity to input texture handling,
expecially when input texture needs go through VP for pixel format
conversion, which IHV D3D12 VP may not handle cropping correctly. For
AV1, since render_size syntax is not for cropping purpose, there is no
way to instruct decoder about visible rect.
As a result, we follow MF VEA's approach to announce support 2-aligned
coded size only.
WebCodecs in blink only blocks non-2-aligned encoding request for H.264
. There should be a way to convey the limitation at MediaCapability
API level, which is not within the scope of this CL.
Bug: 40275246
Change-Id: Ia86e8973ac8a64c66cbb3112fbf6d36de0cb4ef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6805168
Commit-Queue: Jianlin Qiu <[email protected]>
Reviewed-by: Eugene Zemtsov <[email protected]>
Reviewed-by: Sergey Silkin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495243}
Android: remove references to weblayer
No change to logic. WebLayer is no longer supported so we can remove
references to this project.
Bug: 40272607
Test: autoninja system_webview_apk trichrome_webview_apk
Change-Id: Ia5108a8178339c468abd45e33d123482ef8e2827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6807225
Auto-Submit: Nate Fischer <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Commit-Queue: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495242}
Roll Updater chromium_win_x86_64 from 2@1491001 to 2@1495038
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/updater-chromium-win-x86-64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://g-issues.chromium.org/issues/new?component=1516667&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:win-updater-try-builder-rel;luci.chromium.try:linux-updater-try-builder-rel;luci.chromium.try:mac-updater-try-builder-rel;luci.chromium.try:win-updater-try-builder-rel
Tbr: [email protected]
Change-Id: I2c2491fc3db558ec9ee075ffd0324f7f19f8d0cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808135
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495241}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1754005981-79631c2dcedb56c30e83abe4c2447817d1d05c40-1472d1bc9adbbc7279d1446f0abe4e505570da8a.profdata to chrome-mac-arm-main-1754013452-fa1c0847cd7163549dd7c4a2457c5c6f9596870d-7d5f750db0ae836036c8c1f3b4c1ae39d05d0ea9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: If28597d9d02af79187c7610baee63c88a10a6da2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808881
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495240}
Roll clank/internal/apps from 4fde0b9650fd to c84d41b2ac78 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/4fde0b9650fd..c84d41b2ac78
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Ifc1fc79f45b42087596f0b002b1c8aa84f37cd53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809549
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1495239}
Roll DevTools Frontend from c4b03ebbbdd7 to 96c7979dd12e (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4b03ebbbdd7..96c7979dd12e
2025-08-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Chrome (for Testing) PIN
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I082adc8621d986631a3841329cd661a94b71a472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809745
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495238}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1754009601-0ea1e80cde38466a8c6f9f7f9017016b3a569318-bfb4bc46e223f92a8ab9d1235dc33ff6584972b5.profdata to chrome-android64-main-1754015172-1b803716623acd9bf14d6641f1b6acb2f22e32c6-274417bceddff4e68594787065511c2b114a4bb9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I1ab5f0b7d815baa1499a892b5bf297e6dde8db19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809587
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495237}
Bugfix and Cleanup in ManagedPreferencesUtils
Previous changes left this code slightly wrong, legacy case was handling unfollowed recommended preferences. This change fixes that and leaves only custom preferences and custodians on the legacy path. Also added more commenting to make this clearer.
Bug: 429018995
Bug: 400800634
Bug: 400804628
Change-Id: Ia273d7c9e605959ea183f6edf898c65d254aa964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6803334
Reviewed-by: Wenyu Fu <[email protected]>
Commit-Queue: Jack Thiesen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495236}
Roll Updater chromium_linux64 from 2@1491002 to 2@1495011
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/updater-chromium-linux64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://g-issues.chromium.org/issues/new?component=1516667&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:win-updater-try-builder-rel;luci.chromium.try:linux-updater-try-builder-rel;luci.chromium.try:mac-updater-try-builder-rel;luci.chromium.try:win-updater-try-builder-rel
Tbr: [email protected]
Change-Id: I6f360aac934bce4faa1ae39c217809b877a9f7dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808820
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495235}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1753984643-2d9b0172080dc3c51a908c33cad2e3cf9d619714-739f10b7f26e3db54704550f0cea4efc11e28c37.profdata to chrome-win-arm64-main-1754005981-1f2c30daba65f0ae59b864d000f0442c1a15ed10-1472d1bc9adbbc7279d1446f0abe4e505570da8a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Iab0250158ee2394eb1dc1e824d949c95a96c199d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809545
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495234}
Boost cpu priority of discarding renderer processes
With WebContentsDiscard feature, discarding frames are done by blink
running on the renderer process for the main frame of the discarding
page. Boosting process priority of the main frame renderer process is
critical to the discard latency. This is significant on ChromeOS in
which background renderer processes has only 1% of cpu.shares from cpu
cgroups.
Delay of discard latency results in more critical memory pressure
signals and more tab discarding.
Bug: 432390949
Change-Id: I8390836884eb33d9c7b0ea0926e9980e387dd01f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6796029
Commit-Queue: Shin Kawamura <[email protected]>
Reviewed-by: Tom Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495233}
Roll Chrome Android ARM64 Orderfile from 6Md-2cHZdyUZbQgCq... to igSgbfFUiZAaiwKZb...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I52fe11605aad2ff555e729894d1d1da2105b797a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809586
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495232}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1753984643-9ce830037d157f6ffbdf3b3492c53e4ed45ad6a2-739f10b7f26e3db54704550f0cea4efc11e28c37.profdata to chrome-win64-main-1753995572-cb5086c57b1d0335f1548bc774a03e827c57959a-b87085002112c8d70f73ae8dc2f3112d06fc4105.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I2a45b291c8db60b945de0716868570f5c85874c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808437
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495231}
[PA] Propose "ExternalMetadata" synthetic finch trials if enabled
If `enable_move_metadata_outside_gigacage_trial`(gn var) is true,
propose synthetic finch trials: 10% enabled and 10% disabled(control).
Design Doc:
https://docs.google.com/document/d/1Mn-qRAWuDhS_gRL_OG2TYL-EW5D8yljaCyM40S0ocVc/edit?tab=t.0
Bug: crbug.com/435341877
Change-Id: Ib0987efc576d4ba797bed119e18dd595e4d807f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6795727
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Takashi Sakamoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495230}
Roll Amd64 AFDO from 140.0.7327.0_pre1493754_rc-r1-merged to 140.0.7330.0_pre1494797_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I08efd835f66e75f6e43ce9c0f146be554c505327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808818
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495229}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1753984643-76bb98111c1ab01e1538e62047b21c21c7c9ad61-739f10b7f26e3db54704550f0cea4efc11e28c37.profdata to chrome-mac-main-1754005981-7a703d78adafc020cf93fa6c9287c6379ee095f3-1472d1bc9adbbc7279d1446f0abe4e505570da8a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Iae82e89677f8a7c6941fd2ee77978a5f26576b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808329
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495228}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1754004759-dcf498a6609e6fd6c45a32e812c05b64228e3846-2d344d8ece18959de7a5b4ea9efc41cbbf84c98c.profdata to chrome-android64-main-1754009601-0ea1e80cde38466a8c6f9f7f9017016b3a569318-bfb4bc46e223f92a8ab9d1235dc33ff6584972b5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I3301fff787ae2c9c5f71060cfe2db75d22ed378b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808448
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495227}
Roll Chrome Android ARM32 Orderfile from _YL2zhs0P_79KiVZP... to Lh0XWtYoLIW9B5gmA...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I5ebb0937a6002c6f69bf5e5bac40afe26c383f35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6807915
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495226}
Updating trunk VERSION from 7331.0 to 7332.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I86a1a185bd918806da5cd0e7c9b4197fa76d1708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808819
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1495225}
Reland "Capture hit order in AccessibilityNodeInfo for use in Android XR"
This is a reland of commit 3e3ed18252a15de50676d25fd0ced26c439e05d6
Fixing build break when enable_vr=false.
AX-Relnotes: On Android XR, this will fix occlusion issues. On other
AX-Relnotes: platforms should have no effect.
Original change's description:
> Capture hit order in AccessibilityNodeInfo for use in Android XR
>
> In Android XR we have a need to tell, when two accessibility nodes
> overlap, which one is on top, in order to render system hover effects
> correctly. This change attempts to capture the hit order during the
> painting process in the Blink renderer and then pass that on to be
> included in the accessibility extras.
>
> In order to capture the z order across all frames rendered by a single
> renderer process, we capture the CompositorElementIds of all nodes
> passed to PaintChunker::AddHitTestDataToCurrentChunk() and pass them
> through to the cc::Layers, and then finally I use the layer tree to
> compute the final z order values and attach them to the
> AXObjects.
>
> The expensive steps of this process are all protected by platform
> checks to try to eliminate any perf impact on non-XR platforms.
>
> Bug: 410670957
>
> AX-Relnotes: On Android XR, this will fix occlusion issues. On other
> AX-Relnotes: platforms should have no effect.
>
> Test: Loaded up various websites on XR device including Naver.com
> Test: and confirmed that order was as expected. Some small issues
> Test: that appear as the content changes dynamically over time.
> Test: Also ran new test:
> Test: autoninja -C out/Debug content_shell_test_apk && out/Debug/bin/run_content_shell_test_apk --test-filter
> org.chromium.content.browser.accessibility.WebContentsAccessibilityTest#testNodeInfo_extraDataAdded_paintOrder
> Test: Also ran all other WebContentsAccessibilityTest tests.
>
> Change-Id: Ice4e67df7337c2bbda1e20ee474846b61b52c0e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6518162
> Reviewed-by: Mark Schillaci <[email protected]>
> Reviewed-by: Philip Rogers <[email protected]>
> Commit-Queue: Chiara Coetzee <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1494938}
Bug: 410670957
Change-Id: I13f74a9b25658a08fe008d2ee0d5ea9cd1519308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6806931
Reviewed-by: Stefan Zager <[email protected]>
Reviewed-by: Mark Schillaci <[email protected]>
Commit-Queue: Chiara Coetzee <[email protected]>
Reviewed-by: Matthew Denton <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Reviewed-by: Alexander Cooper <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495224}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1753973894-18936bb1e43ebdbe47172c87e6f542fea8841f66-c9533bc9b264b16d981279e48012260a19ecb774.profdata to chrome-win32-main-1753984643-35a68821a6616d49a5e282df39fe0c1f455ed20c-739f10b7f26e3db54704550f0cea4efc11e28c37.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Icaf812e922823fb9dbf2213350bb951fd67b0b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6807923
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1495223}