Skip to content

Fix update-bundle workflow #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2025
Merged

Fix update-bundle workflow #3073

merged 2 commits into from
Sep 2, 2025

Conversation

aibaars
Copy link
Collaborator

@aibaars aibaars commented Sep 2, 2025

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.
  • High risk: Changes are not fully under feature flags, have limited visibility and/or cannot be tested outside of production.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@aibaars aibaars requested a review from a team as a code owner September 2, 2025 15:29
@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 15:29
@aibaars aibaars force-pushed the aibaars/update-bundle branch from 6f63204 to 5864756 Compare September 2, 2025 15:29
Copilot
Copilot AI reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the update-bundle workflow by adding a missing dependency installation step. The workflow is triggered when a CodeQL bundle prerelease is published and automates the process of updating the default bundle version.

  • Adds npm ci step to install dependencies before running build commands

henrymercer
henrymercer previously approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could we also add a:

      - name: Set up Node.js
        uses: actions/setup-node@v4
        with:
          node-version: '20.x'
          cache: 'npm'

step? That'll cache the dependencies and should speed things up.

@aibaars aibaars force-pushed the aibaars/update-bundle branch from 5864756 to d5dbc12 Compare September 2, 2025 17:26
@aibaars aibaars enabled auto-merge September 2, 2025 17:39
henrymercer
henrymercer approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aibaars aibaars merged commit 16df4fb into main Sep 2, 2025
278 checks passed
@aibaars aibaars deleted the aibaars/update-bundle branch September 2, 2025 17:52
@github-actions github-actions bot mentioned this pull request Sep 5, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibaars @henrymercer