refactor(codegen): use graphql.Config type #4017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomoikey
force-pushed
the
refactor/generated-go
branch
from
d636ef0 to
24df78f
Compare
tomoikey
commented
Feb 7, 2026
Comment on lines
-24
to
-35
| eq, msg := eqgo.PackagesEquivalent( | ||
| singlefilePkg, | ||
| singlefileFSet, | ||
| followschemaPkg, | ||
| followschemaFSet, | ||
| nil, | ||
| ) | ||
| if !eq { | ||
| // When msg is too long, require.True(...) omits it entirely. | ||
| // Therefore use fmt.Fprintln to print it manually instead. | ||
| fmt.Fprintln(os.Stderr, msg) | ||
| require.Fail(t, "Packages not equivalent") |
Contributor
Author
There was a problem hiding this comment.
eq-go does not support Go 1.18 generics (ast.IndexListExpr) and panics when it encounters them.
Since the library is no longer maintained, this PR replaces it with comparison using the standard library's go/printer.
type Config[R any, D any, C any] struct {
Schema *ast.Schema
Resolvers R
Directives D
Complexity C
}
tomoikey
commented
Feb 7, 2026
Comment on lines
+70
to
+72
| if gd, ok := decl.(*ast.GenDecl); ok && gd.Tok == token.IMPORT { | ||
| continue | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This skips import comparison. Since matching declarations will inherently produce matching imports, there's little value in comparing them separately. It also avoids some awkward edge cases around import handling. I don't think this causes any real problems in practice.
Collaborator
There was a problem hiding this comment.
Seems reasonable to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the code currently living in the templates doesn't need to be part of the generated output. Moving these pieces into static .go files helps keep generated.go simpler and easier to maintain.
There are several places where this applies, so I'll be sending a series of smaller PRs rather than one large change. As a first step, this PR extracts the Config struct into the graphql package.
I have: