Added A Password visibility toggle button To Login Page #1080
Conversation
Minor enhancements
… docker-compose. People are getting tripped up by installs that aren't up to date
* fix#982 * update * Handle Burp Collaborator issues This is an enhancement in order to handle findings that contain Burp collaborator interactions which have additional request/response pairs and additional information that was normally ignored or breaking the importing of the report . * Fix flake8 errors * More accessibility fixes for top and side menu * Made search button accessible * tune uwsgi read timeout (troubleshoots 'upstream timed out' on POST import_scan_results) * add a different docker-compose for dev and for release * add a different docker-compose for dev and for release * Update README.md * cicd engagement: after delete return to cicd engagement view * Updated DOCKER.md in dev branch to include info on checking versions for docker and docker-compose. People are getting tripped up by installs that aren't up to date * Docker readme update * Travis compose sourcing script * Github template DB addition, docker sourcing
|
I did nt add that..dont even know what it's for...it came when i pulled updates before making a push. But i have removed it now. |
There was a problem hiding this comment.
Hey @propersam the dojo/unittests/test_dependency_check_parser.py seems to have also been removed by accident , not sure what happened there ? Also , this looks great but I was wondering if we should take the approach of the "eye svg" icon that you click to toggle instead of a checkbox ? @aaronweaver
|
Like the change as well but agree with @adracea on "eye svg" |
|
The form is auto generated by django. I could nt edit the input box for password to fix in the eye svg icon. But let me see if i cn change checkbox to d eye svg icon. In the same position where checkbox currently is. |
|
How abt now. @aaronweaver @adracea How do you see it. I can't use button for the toggle because buttons automatically submits the form. And I can't put the SVG eye icon inside the password input box because it is auto generated by django form. That's why I wrapped the toggle icon in a clickable div element. |
|
Your PR still has this file removed, which I don't think is intended? |
|
The file in this commit: |
|
Even if it was intentional I don't think it should be part of this PR. |
|
Oh. Well, i don't really know what to do now. I couldn't make a push until i pulled all updates from dev branch. And the above commit updates not made by me where pulled into my code before i was able to push my own update. Please, What do you suggest i do to make the PR the way it should be. Because i don't know if git has the functionality to control what updates come in and which ones don't during a pull request without causing a merge incompatibility. |
|
Getting it right "the git way" may be a bit of challenge, can't see exactly what happened there. Can't find that commit anywhere else but in this PR. |
|
I have restored the file. |
|
Thanks, just needs a newline at the end of that file to make it flake8 compliant (and risk to the dev branch) |
|
@valentijnscholten @adracea Are we ok with merging? Looks like all changes have been addressed. |
6 participants
For good User experience sake, I find it stressful when I just copy and paste password into the login page or type blindly into the password field without knowing what was entered. Sometimes my keyboard even enters a key twice and then there's no way of cross checking what I typed in like logging in to my gmail account for example. So I decided to take my time to add the toggle password functionality to the login page for myself and made a pull request in case of someone else that might need it. 😃