Skip to content

Sonatype parser #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2019
Merged

Sonatype parser #1182

merged 1 commit into from
May 28, 2019

Conversation

madchap
Copy link
Contributor

@madchap madchap commented May 25, 2019 •
edited
Loading

Got my hand on a sonatype json report. This is a parser based on it (which I cannot share).
The unittests have a glimpse of what it looks like though.

Cheers,
fred

Please submit your pull requests to the 'dev' branch.

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes should include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.

@madchap madchap mentioned this pull request May 25, 2019
Merged
@valentijnscholten
Copy link
Member

I see that you also addAcunetix and Kiuwan strings to a list in the import scan results, I guess these were just missed before and are added now to make the list complete.

@adracea adracea merged commit 90219c9 into DefectDojo:dev May 28, 2019
@madchap
Copy link
Contributor Author

madchap commented May 28, 2019 •
edited
Loading

I see that you also addAcunetix and Kiuwan strings to a list in the import scan results, I guess these were just missed before and are added now to make the list complete.

@valentijnscholten : No, they were just not put in the right alphabetical order. Since it is pure HTML, there is no automatic sorting.

@madchap madchap deleted the sonatype-parser branch June 9, 2019 14:45
@aaronweaver aaronweaver mentioned this pull request Jun 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentijnscholten valentijnscholten valentijnscholten approved these changes

+1 more reviewer

@adracea adracea adracea approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madchap @valentijnscholten @adracea