Fix bad element map in Part Design Bodies #22767
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mod: Part Design
|
there is a failing toponaming check -- its likely caused by fix being run every time a shape property is updated. this could be an ok thing to fail, and we might want to change the check? |
|
ok so i figured out that using fix is not the proper thing to do, the swap of the elementmap from the originalshape to the newshape isnt working here for some reason it has to do with reinstating the hasher from what I can tell |
2 tasks
|
this is sort of a weak patch instead of a proper fix, i will do more digging to find the original issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a line that calls a method to fix the element map every time you run setShape
this change can be found in realthunder's branch.
fixes: #22395
fixes: #20277
might need testing for crash detection