-
Notifications
You must be signed in to change notification settings - Fork 236
feat: NVIDIA-Llama-Nemotron-Super-49B #4430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Sam-Deciga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new official Jupyter notebook designed to guide users through the process of deploying and interacting with NVIDIA's Llama Nemotron models on Google Cloud's Vertex AI platform. It provides comprehensive instructions and code examples for model registration, endpoint creation, model deployment, and real-time prediction, utilizing both direct API calls and the Vertex AI Python SDK. The notebook focuses on the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Jupyter notebook for deploying NVIDIA Llama Nemotron models on Google Cloud Vertex AI. The notebook demonstrates both API and Python SDK methods for model upload, endpoint creation, deployment, and prediction. Overall, the notebook provides a good starting point for users. However, there are several areas where the robustness and clarity of the code can be improved, particularly concerning resource ID extraction and consistency in naming conventions.
|
Checked with the partner and they say they are OK |
|
Thanks for the clear PR template and checklists. The required summary (“why the change is needed,” “what was changed,” and design alternatives), along with CODEOWNERS attribution and environment verification (e.g., Colab runs), creates a strong authorship and accountability signal that’s easy for reviewers to reason about. The explicit cleanup requirements for generated artifacts are also helpful for maintaining long-term repo and resource hygiene. Overall, this structure makes review intent, ownership, and execution boundaries much clearer up front. Appreciate the rigor. |
|
Since MODEL_ID already contains the fully qualified resource path, re-concatenating it with projects/{PROJECT_ID}/locations/{LOCATION}/models/ would indeed produce a malformed identifier. Using the existing MODEL_ID value directly for the "model" field keeps the payload aligned with the expected resource name format and avoids duplication. Appreciate the clear explanation in the review comment — it makes the correction unambiguous. |
REQUIRED: Add a summary of your PR here, typically including why the change is needed and what was changed. Include any design alternatives for discussion purposes.
--- YOUR PR SUMMARY GOES HERE ---
NVIDIA Llama Nemotron Super 49B v1.5 model launch on Jan 28
b/454127910
REQUIRED: Fill out the below checklists or remove if irrelevant
Official Notebooksunder the notebooks/official folder, follow this mandatory checklist:Official Notebookssection, pointing to the author or the author's team.Community Notebooksunder the notebooks/community folder:Community Notebookssection, pointing to the author or the author's team.Community Contentunder the community-content folder:Content Directory Nameis descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other contentCommunity Contentsection, pointing to the author or the author's team.