fix(dart): add file name to formatter#6665
Closed
jordyslagter wants to merge 1 commit intoLazyVim:mainfrom
jordyslagter:fix/dart-format
Closed
fix(dart): add file name to formatter#6665jordyslagter wants to merge 1 commit intoLazyVim:mainfrom jordyslagter:fix/dart-format
jordyslagter wants to merge 1 commit intoLazyVim:mainfrom
jordyslagter:fix/dart-format
Conversation
Fix dart_format failing to format because there wasn't a file name included.
github-actions
bot
added
extras
extras-lang
size/xs
Contributor
|
My suggestion would be the same as #6156. Just remove lines 23-27. These settings get inherited from |
Collaborator
|
Agreed, that's just not needed. Remove those lines |
Contributor
|
Along with this PR, I would also suggest to make a change to Solidity Extra and remove these lines as well on the same precipice LazyVim/lua/lazyvim/plugins/extras/lang/solidity.lua Lines 35 to 40 in e8a1d8b In general it would be a good guideline to avoid overwriting |
folke
pushed a commit
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- ## [15.11.0](v15.10.1...v15.11.0) (2025-10-23) ### Features * **snacks_picker:** added gai/gao keymaps for calls incoming/outgoing ([b6e48a5](b6e48a5)) * **snacks.picker:** added `<leader>gD` to diff against merge base of branch/PR ([f0a91d9](f0a91d9)) ### Bug Fixes * **avante:** unset default keymaps ([#6657](#6657)) ([e8a1d8b](e8a1d8b)) * **extras:** remove custom formatter opts for dart/solidity. Closes [#6665](#6665) ([b38de4e](b38de4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
NanoBoom
pushed a commit
to NanoBoom/LazyVim
that referenced
this pull request
Oct 25, 2025
🤖 I have created a release *beep* *boop* --- ## [15.11.0](LazyVim/LazyVim@v15.10.1...v15.11.0) (2025-10-23) ### Features * **snacks_picker:** added gai/gao keymaps for calls incoming/outgoing ([b6e48a5](LazyVim/LazyVim@b6e48a5)) * **snacks.picker:** added `<leader>gD` to diff against merge base of branch/PR ([f0a91d9](LazyVim/LazyVim@f0a91d9)) ### Bug Fixes * **avante:** unset default keymaps ([#6657](LazyVim/LazyVim#6657)) ([e8a1d8b](LazyVim/LazyVim@e8a1d8b)) * **extras:** remove custom formatter opts for dart/solidity. Closes [#6665](LazyVim/LazyVim#6665) ([b38de4e](LazyVim/LazyVim@b38de4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dart_format failing to format because there wasn't a file name included.
Description
I noticed the dart formatter wasn't working when installing the lang.dart extra without adding any of my own configuration. I tested this in a Docker container with a new install of LazyVim and lang.dart as well and the problem happens there as well.
The problem originates from the $FILENAME not being included in the dart format command, this PR adds that and thus fixes the formatting for dart.
Related Issue(s)
Screenshots
Checklist