fix(tabbar):使用非官方tabbar自定义后，h5 页面没有高度样式导致空白 #17857

felix9ia · 2025-06-20T02:57:33Z

这个 PR 做了什么？ (简要描述所做更改)

这个 PR 是什么类型？ (至少选择一个)

错误修复 (Bugfix) issue: fix #
新功能 (Feature)
代码重构 (Refactor)
TypeScript 类型定义修改 (Types)
文档修改 (Docs)
代码风格更新 (Code style update)
构建优化 (Chore)
其他，请描述 (Other, please describe):

这个 PR 涉及以下平台：

Summary by CodeRabbit

样式优化
- 优化了底部 TabBar 容器和面板的样式，确保其高度始终占满 100%。

coderabbitai · 2025-06-20T02:57:39Z

"""

Walkthrough

本次更改在 loadRouterStyle 函数中，当 enableTabBar 为真时，新增了针对 .taro-tabbar__container 和 .taro-tabbar__panel 的 CSS 规则，将它们的高度设置为 100%。其他逻辑和函数行为未发生变化。

Changes

文件/分组	变更摘要
packages/taro-router/src/style.ts	在 `enableTabBar` 为真时，新增 `.taro-tabbar__container` 和 `.taro-tabbar__panel` 的 `height: 100%` 样式规则。

Possibly related issues

[Bug]: 自定义 tabbar 后，h5 模式下页面空白，taro-tabbar__container 和 taro-tabbar__panel没有设置高度 #17856：本 PR 直接为 .taro-tabbar__container 和 .taro-tabbar__panel 添加了 height 规则，解决了该 issue 中描述的布局问题。

Suggested reviewers

Single-Dancer

Poem

小兔跳进代码林，
样式高高挂满屏。
TabBar 伸展百分百，
页面布局更整齐。
一行 CSS，春风起，
代码世界添新意！
🐇✨
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91b55b1 and 5f8d9fb.

📒 Files selected for processing (1)

packages/taro-router/src/style.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/taro-router/src/style.ts

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Build Rust Binding / stable - x86_64-unknown-linux-gnu
GitHub Check: Build Rust Binding / stable - x86_64-pc-windows-msvc
GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin
GitHub Check: Build Rust Binding / stable - x86_64-apple-darwin
GitHub Check: Build Rust WASM / stable - wasm32-wasi

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/taro-router/src/style.ts (1)
58-63: 修复方案正确，建议统一格式

CSS 规则的逻辑正确，通过设置 height: 100% 确保 tabbar 容器占满可用高度，有效解决了自定义 tabbar 导致的空白页面问题。

建议统一 CSS 属性的格式：
  .taro-tabbar__container {
-      height:100%;
+      height: 100%;
  }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f097d5 and 91b55b1.

📒 Files selected for processing (1)

packages/taro-router/src/style.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin
GitHub Check: Build Rust Binding / stable - x86_64-unknown-linux-gnu
GitHub Check: Build Rust Binding / stable - x86_64-unknown-linux-musl
GitHub Check: Build Rust Binding / stable - x86_64-apple-darwin
GitHub Check: Build Rust Binding / stable - x86_64-pc-windows-msvc
GitHub Check: Build Rust WASM / stable - wasm32-wasi

codecov · 2025-06-20T03:14:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.90%. Comparing base (5fd52a3) to head (5f8d9fb).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #17857    +/-   ##
========================================
  Coverage   55.90%   55.90%            
========================================
  Files         417      417            
  Lines       21693    21693            
  Branches     5378     5349    -29     
========================================
  Hits        12127    12127            
+ Misses       8081     7967   -114     
- Partials     1485     1599   +114

Flag	Coverage Δ
taro-cli	`72.42% <ø> (ø)`
taro-runtime	`59.87% <ø> (ø)`
taro-web	`53.19% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 46 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

felix9ia · 2025-06-20T03:23:48Z

我的用是 taroify 的 tabbar，并非官方的 tabbar 组件....

taro 官方的 tabbar 确实添加了这个样式....但是前提是用了官方的 tabbar ......

coderabbitai bot requested a review from Single-Dancer June 20, 2025 02:57

felix9ia mentioned this pull request Jun 20, 2025

[Bug]: 自定义 tabbar 后，h5 模式下页面空白，taro-tabbar__container 和 taro-tabbar__panel没有设置高度 #17856

Open

13 tasks

coderabbitai bot reviewed Jun 20, 2025

View reviewed changes

felix9ia changed the title ~~fix(tabbar):自定义tabbar后，h5 页面没有高度样式导致空白~~ fix(tabbar):使用非官方tabbar自定义后，h5 页面没有高度样式导致空白 Jun 23, 2025

Single-Dancer added this to the 4.1.4 milestone Jun 23, 2025

Single-Dancer approved these changes Jun 23, 2025

View reviewed changes

fix(tabbar):自定义tabbar后，h5 页面没有高度样式导致空白

5f8d9fb

Single-Dancer force-pushed the main branch from 91b55b1 to 5f8d9fb Compare June 23, 2025 06:19

Single-Dancer merged commit 5684874 into NervJS:main Jun 23, 2025
24 checks passed

Single-Dancer mentioned this pull request Jun 30, 2025

chore(release): publish 4.1.3 #17932

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(tabbar):使用非官方tabbar自定义后，h5 页面没有高度样式导致空白 #17857

fix(tabbar):使用非官方tabbar自定义后，h5 页面没有高度样式导致空白 #17857

Uh oh!

felix9ia commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

codecov bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

felix9ia commented Jun 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix(tabbar):使用非官方tabbar自定义后，h5 页面没有高度样式导致空白 #17857

fix(tabbar):使用非官方tabbar自定义后，h5 页面没有高度样式导致空白 #17857

Uh oh!

Conversation

felix9ia commented Jun 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related issues

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

felix9ia commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felix9ia commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jun 20, 2025 •

edited

Loading

felix9ia commented Jun 20, 2025 •

edited

Loading