Skip to content

dash-mpd-cli: deprecate phases #429185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

dash-mpd-cli: deprecate phases #429185

merged 1 commit into from
Jul 29, 2025
+5 −8

Conversation

Stunkymonkey
Copy link
Contributor

part of #28910

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 28, 2025
@nix-owners nix-owners bot requested a review from al3xtjames July 28, 2025 20:30
@Stunkymonkey
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 429185
Commit: c5131e683e82074fdf839bf7156102e090b227c5

x86_64-linux

✅ 1 package built:
  • dash-mpd-cli

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 29, 2025
@phanirithvij
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 429185

Logs: https://github.com/phanirithvij/nixpkgs-review-gha/actions/runs/16588938163

x86_64-linux

✅ 1 package built:
  • dash-mpd-cli

aarch64-linux

✅ 1 package built:
  • dash-mpd-cli

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • dash-mpd-cli

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • dash-mpd-cli

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 29, 2025
@Stunkymonkey Stunkymonkey merged commit eaa9fd3 into NixOS:master Jul 29, 2025
32 of 34 checks passed
@Stunkymonkey Stunkymonkey deleted the dash-mpd-cli-phases branch July 29, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al3xtjames al3xtjames al3xtjames approved these changes

@phanirithvij phanirithvij phanirithvij approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @phanirithvij @al3xtjames