Fix a bug in how Write-Host handles XML Elements #24669
Merged
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Changes how the
Write-Host
cmdlet handles XMLElements, fixes #24508PR Context
I'm not positive this is the right fix, spiritually I could get behind using
.OuterXml
instead which would print the whole XML document from that element, which seems aligned with the iteration of an Enumerable.Either way, it is definitely the case that the current code doesn't work as expected.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [X] Issue filed:
Write-Host
renders an[xml]
or[XmlElement]
instance as an empty line. #24508(which runs in a different PS Host).