Skip to content

Seal internal type ClientRemoteSessionDSHandlerImpl #24705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xtqqczze
Copy link
Contributor

Contributes to #24094.

Seal internal type System.Management.Automation.Remoting.ClientRemoteSessionDSHandlerImpl in src/System.Management.Automation/engine/remoting/client/remotingprotocolimplementation.cs

The motivation of this PR is this comment by @PaulHigin #11820 (comment).

@xtqqczze
Copy link
Contributor Author

D:\a\1\s\src\System.Management.Automation\engine\remoting\client\remotingprotocolimplementation.cs(752,24): error CS0628: 'ClientRemoteSessionDSHandlerImpl.Dispose(bool)': new protected member declared in sealed type [D:\a\1\s\src\System.Management.Automation\System.Management.Automation.csproj]

@xtqqczze
Copy link
Contributor Author

@iSazonov checks successful, can we merge?

@iSazonov iSazonov self-assigned this Dec 25, 2024
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 25, 2024
@iSazonov iSazonov merged commit 8017195 into PowerShell:master Dec 25, 2024
38 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Dec 25, 2024

📣 Hey @xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@xtqqczze xtqqczze deleted the seal-ClientRemoteSessionDSHandlerImpl2 branch December 25, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants