created TLP classes as defined in spec by anlklsim · Pull Request #97 · StephenOTT/STIX-Java

anlklsim · 2019-05-10T16:29:21Z

The STIX spec defines the exact ID and created date for the 4 TLP markings. I defined them in a class as static values and created a test Spec. It's interesting that the markings do not need to be within the bundle.

Note that the Stix Mocking for TLP Marking defs makes up custom properties, but they are not really allowed for the TLP markings.

StephenOTT · 2019-05-10T20:21:48Z

Great stuff.

I am waiting for a response on this: oasis-tcs/cti-stix2#152 before merging.

The extreme limitation on the TLPs is very weird, and would like to document its usage before we implement the rest of the TLPs

Further tasks:

~~Update the TLPs to remove custom props~~ Custom props are provided by marking def. The Custom props have been removed from the Mock generator for TLPs
Add a config override to allow a implementation to allow custom parsing of TLPs without having to create custom objects...
Add logic on deserialization to validate against the new Tlps class that @anlklsim has provided
Add some helper logic on object build to validate that the TLP is matched to the spec limitations/requirements.

src/main/java/io/digitalstate/stix/datamarkings/objects/Tlps.java

StephenOTT · 2019-05-10T20:26:31Z

src/test/groovy/stix/datamarkings/TLPmarkingsSpec.groovy

+import spock.lang.Shared
+import spock.lang.Specification
+
+/**


review usage of author javadoc tag as its starting to be deprecated in tooling like apache and gradle

src/test/groovy/stix/datamarkings/TLPmarkingsSpec.groovy

StephenOTT · 2019-05-10T20:28:58Z

src/test/groovy/stix/datamarkings/TLPmarkingsSpec.groovy

+		MarkingDefinition green = Tlps.TLP_GREEN;
+		StixInstant now = new StixInstant();
+
+		Indicator ind = Indicator.builder()


Lets move this into a json file similar to the Bundle tests. The current test is basically a duplicate of the mock generation test. The json file tests is a "hardened" data example where the json file represents the "pure" unchanging json to test against

Conflicts: src/test/groovy/stix/datamarkings/TLPmarkingsSpec.groovy

StephenOTT · 2019-05-17T13:45:14Z

@anlklsim what scenario causes the NPE that you fixed for the getCause() ?

anlklsim · 2019-05-17T13:51:18Z

I had mistakenly called STIXParsers.parseObject on my bundle in my test, which threw an IOExeption in the method (since it was not a BundleableObject), and the if statement threw an NPE on ex.getClause() and therefore only the NPE was logged in the Junit as the error (hiding the true exception message). Stepping thru the debugger, I saw the error, added the null check, and then the true error printed out. Only then, did I notice that I was calling the wrong method. I added the same check to parseBundle to be complete.

created TLP classes as defined in spec

35620c4