Skip to content

refactor(router-core): route matching only needs string parts for 'from', not full segments (WIP) #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor(router-core): route matching only needs string parts for 'from', not full segments (WIP) #5054

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e46861c
refactor(router-core): route matching only needs string parts for 'fr…
Sheraff Aug 30, 2025
fa294cc
ci: apply automated fixes
autofix-ci[bot] Aug 30, 2025
daf4e70
parseRouteCache is only a Map
Sheraff Aug 30, 2025
7816b7a
fix single slash case
Sheraff Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
parseRouteCache is only a Map
  • Loading branch information
@Sheraff
Sheraff committed Aug 30, 2025
commit daf4e70fa079e202ed18f78daf1c9c42dc8961b4
2 changes: 1 addition & 1 deletion packages/router-core/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,7 @@ export class RouterCore<
}

/** a cache of parsed routes for `parsePathname` (e.g. `/foo/$bar` => Array<Segment>) */
private parseRouteCache: ParseRouteCache = createLRUCache(500)
private parseRouteCache: ParseRouteCache = new Map()
/** a cache of parsed pathnames for `parsePathname` (e.g. `/foo/123` => Array<string>) */
private parsePathCache: ParsePathCache = createLRUCache(500)

Expand Down
Loading