Skip to content

Enhance cache-dependency-path handling to support files outside the workspace root #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 25, 2025
+243 −5
Merged

Enhance cache-dependency-path handling to support files outside the workspace root #1128

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f36c837
ehnace cache dependency path handling
aparnajyothi-y Jun 9, 2025
0511a23
logic update
aparnajyothi-y Jun 9, 2025
b641d7d
npm run format-check
aparnajyothi-y Jun 9, 2025
566d40e
update cacheDependencies tests to cover resolved paths and copy edge …
aparnajyothi-y Jun 9, 2025
8ae6b15
check failure fix
aparnajyothi-y Jun 9, 2025
e0348c8
depricate-windows-2019
aparnajyothi-y Jun 18, 2025
6d7172d
refactored the code
aparnajyothi-y Jun 19, 2025
fab5a1e
Check failure fix
aparnajyothi-y Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactored the code
  • Loading branch information
@aparnajyothi-y
aparnajyothi-y committed Jun 19, 2025
commit 6d7172dabe9cbbe2ca951c523a331d600f62ac3c
8 changes: 4 additions & 4 deletions dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96947,14 +96947,14 @@ function cacheDependencies(cache, pythonVersion) {
// Copy file asynchronously
yield fs_1.default.promises.copyFile(sourcePath, targetPath);
core.info(`Copied ${sourcePath} to ${targetPath}`);
resolvedDependencyPath = path
.relative(workspace, targetPath)
.replace(/\\/g, '/');
core.info(`Resolved cache-dependency-path: ${resolvedDependencyPath}`);
}
else {
core.info(`Dependency file is already inside the workspace: ${sourcePath}`);
}
resolvedDependencyPath = path
.relative(workspace, targetPath)
.replace(/\\/g, '/');
core.info(`Resolved cache-dependency-path: ${resolvedDependencyPath}`);
}
}
catch (error) {
Expand Down
12 changes: 7 additions & 5 deletions src/setup-python.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,18 @@ export async function cacheDependencies(cache: string, pythonVersion: string) {
// Copy file asynchronously
await fs.promises.copyFile(sourcePath, targetPath);
core.info(`Copied ${sourcePath} to ${targetPath}`);

resolvedDependencyPath = path
.relative(workspace, targetPath)
.replace(/\\/g, '/');
core.info(
`Resolved cache-dependency-path: ${resolvedDependencyPath}`
);
} else {
core.info(
`Dependency file is already inside the workspace: ${sourcePath}`
);
}

resolvedDependencyPath = path
.relative(workspace, targetPath)
.replace(/\\/g, '/');
core.info(`Resolved cache-dependency-path: ${resolvedDependencyPath}`);
}
} catch (error) {
core.warning(
Expand Down
Loading