hi,

thanks for the PR.

could you please reduce this to just porting PyMySQL/PyMySQL#923?
that will still be compatible with PyMySQL <1.0.0 (although I do intend to raise this before aiomysql 1.0.0 will be released)
for pack_int24 and lenenc_int I think it makes more sense to vendor these (e.g. in #554) instead of accessing non-public API of PyMySQL.

hi,

thanks for the PR.

could you please reduce this to just porting PyMySQL/PyMySQL#923? that will still be compatible with PyMySQL <1.0.0 (although I do intend to raise this before aiomysql 1.0.0 will be released) for pack_int24 and lenenc_int I think it makes more sense to vendor these (e.g. in #554) instead of accessing non-public API of PyMySQL.

something like that?

thank you, this is what I was thinking of.

in tests/test_basic.py there's another reference to pymysql.util, with that updated the tests should run properly.

when CI and linter are green this should be good to merge.

Codecov Report

Merging #643 (6df06f3) into master (624de5f) will decrease coverage by 0.40%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   86.50%   86.10%   -0.41%     
==========================================
  Files          12       12              
  Lines        2082     2094      +12     
  Branches      341      346       +5     
==========================================
+ Hits         1801     1803       +2     
- Misses        216      224       +8     
- Partials       65       67       +2     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624de5f...6df06f3. Read the comment docs.

thanks!